Sequencer scripting#404
Draft
astronomerdave wants to merge 13 commits intoissue-363-slicecam-acquire-v2from
Draft
Sequencer scripting#404astronomerdave wants to merge 13 commits intoissue-363-slicecam-acquire-v2from
astronomerdave wants to merge 13 commits intoissue-363-slicecam-acquire-v2from
Conversation
Implements slicecam fine acquisition * Introduced slicecam_math.cpp/h implementing centroid detection, WCS pix2world conversion, and angular offset calculations. * Added a do_fineacquire loop to the Slicecam interface to automate target centering based on configurable aimpoints and background regions. * Added FINE_ACQUIRE_AIMPOINT and FINE_ACQUIRE_BACKGROUND parameters to the daemon configuration. * Replaces receiving a JSON message with the existing PUB-SUB mechanism * Updated target_offset logic to better distinguish between TCS-direct offsets and ACAM-guided goal offsets. * Renamed dothread_acquisition to do_acam_acquire and added atomic tracking for fine-acquisition locks and guiding states.
changes std::string to string_view where string not needed
moves wait_for_XXXX wrappers to a separate file moves sequence building tools to a separate file
* adds subscriber topic handlers to sequencerd * introduces a command handler header-only lib (WIP, not implemented)
astronomerdave
force-pushed
the
sequencer-scripting
branch
from
ec93b5d to
39ab927
Compare
updates Sequencer::Sequence::run() to use this for retry on error, and uses this to tidy the startup() sequence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a sequencer command language (SCL) to provide a safer controlled interface for users to issue commands to the instrument, either through individual commands or through custom scripting.