Skip to content

fix(tools): harden workspace file mutations#58

Merged
euxaristia merged 1 commit into
Cairn:mainfrom
PierrunoYT:fix/c03-workspace-confinement
Jul 24, 2026
Merged

fix(tools): harden workspace file mutations#58
euxaristia merged 1 commit into
Cairn:mainfrom
PierrunoYT:fix/c03-workspace-confinement

Conversation

@PierrunoYT

Copy link
Copy Markdown
Collaborator

Summary

  • route file write, edit, history, and undo operations through the opened workspace directory capability
  • reject parent path components before any filesystem access
  • remove the ambient absolute-path resolver and preserve confinement across missing paths and link/reparse-point traversal
  • add regression tests proving junction/symlink escapes do not create or modify outside files

Validation

  • cargo test --locked
  • cargo build --locked
  • git diff --check

Closes #13

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@PierrunoYT, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d17efcfe-299c-4032-af74-c1980d6c90f7

📥 Commits

Reviewing files that changed from the base of the PR and between 7ebe4f4 and 9fbdc37.

📒 Files selected for processing (6)
  • src/tools/file_edit.rs
  • src/tools/file_history.rs
  • src/tools/file_undo.rs
  • src/tools/file_write.rs
  • src/tools/registry.rs
  • src/tools/workspace.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@euxaristia euxaristia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved after audit.

@euxaristia
euxaristia merged commit 6459b8a into Cairn:main Jul 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Critical][C-03] Fix workspace confinement bypass for new paths

2 participants