fix(tui): route exit commands through cleanup#54
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019f8ea9-e83b-75b8-ad3a-f854d7006340 Co-authored-by: Pierre Bruno <pierrebruno@hotmail.ch>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesTUI exit control
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
euxaristia
left a comment
There was a problem hiding this comment.
LGTM! Approved after audit.
Summary
std::process::exit(0)/exit,/quit, and/qthrough the existing clean TUI shutdown path so autosave, mouse cleanup, and terminal restoration runCloses #27.
Validation
cargo test --locked exit_tests(1 passed)RUSTFLAGS=-Dwarnings cargo test --locked(278 passed)cargo fmt --all -- --check(reports pre-existing formatting drift acrosssrc/tui.rs; unrelated whole-file formatting was intentionally not included)git diff --checkSummary by CodeRabbit
Bug Fixes
/exit,/quit, and/qcommands so the terminal interface closes cleanly.Tests