Fix normals for located planar wires#2071
Open
lorenzncode wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2071 +/- ##
=======================================
Coverage 95.70% 95.70%
=======================================
Files 30 30
Lines 9479 9480 +1
Branches 1410 1410
=======================================
+ Hits 9072 9073 +1
Misses 253 253
Partials 154 154 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adam-urbanczyk
left a comment
adam-urbanczyk
left a comment
Member
There was a problem hiding this comment.
Thanks @lorenzncode , I think same fix needs to be applied to two other locations in that function.
| rv = Vector(circ.Axis().Direction()) | ||
| elif gtype == "ELLIPSE": | ||
| ell = curve.Ellipse() | ||
| rv = Vector(ell.Axis().Direction()) |
|
|
||
| if gtype == "CIRCLE": | ||
| circ = curve.Circle() | ||
| rv = Vector(circ.Axis().Direction()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2070