Better imprint for assy#2069
Open
adam-urbanczyk wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2069 +/- ##
=======================================
Coverage 95.70% 95.70%
=======================================
Files 30 30
Lines 9479 9479
Branches 1410 1410
=======================================
Hits 9072 9072
Misses 253 253
Partials 154 154 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lorenzncode
approved these changes
Jul 18, 2026
| """ | ||
| Imprint all the solids and construct a dictionary mapping imprinted solids to names from the input assy. | ||
|
|
||
| Depending on the use case, it might be required do use different `glue` option. Moreover, for large models |
Member
There was a problem hiding this comment.
Perhaps the same comment regarding glue might be added to:
cadquery/cadquery/occ_impl/shapes.py
Line 6964 in b47f7b7
Depending on the use case, it might be required do use different `glue` option.
| ids = tuple(id_map[Solid(el)] for el in bldr.GetOrigins(s.wrapped)) | ||
| # if GetOrigins yields nothing, solid was not modified | ||
| if ocp_origins.IsBound(s.wrapped): | ||
| # if GetOrigins yields nothing, solid was not modified |
Member
There was a problem hiding this comment.
In comment, GetOrigins was from the old implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Low level fix enabling faster imprints for well behaved models.
NB: this PR also contains a typing fix related to Numba version update.