Conversation
- Phase 1: husky v9 + lint-staged 설정 (pre-commit 시 ESLint + Prettier) - Phase 2: commitlint (Conventional Commits 강제, 한국어 허용) - Phase 3: deploy.yml에 tsc/test 추가, pr-check.yml 신규 워크플로우 - Phase 4: Jest 커버리지 임계값 설정 (A 방식, 보수적 시작) - Phase 5: TypeScript strict: true 전환 (DateTimeScalar 1건 수정) - Phase 6: PR 자동화 (커버리지 리포트 댓글, PR 타이틀 lint)
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughPR은 CI/CD 파이프라인과 Git 훅을 추가하여 커밋 메시지 검증, GraphQL 코드 생성, 타입 체크, 린트, 테스트 자동화를 구성합니다. TypeScript 엄격 모드를 활성화하고 런타임 타입 검증을 강화합니다. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
changed the title
- coverage-report job에 pull-requests: write 권한 추가 - GITHUB_TOKEN 기본 권한이 read-only여서 댓글 작성 실패하던 문제 해결
This comment was marked as resolved.
This comment was marked as resolved.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/pr-check.yml:
- Around line 1-10: Add an explicit permissions block to the PR Check workflow
(the top-level "name: PR Check" / "on: pull_request" definition) to enforce
least-privilege access instead of relying on defaults, and where specific jobs
(see the jobs referenced around concurrency and the job definitions) need
different rights, override them with job-level permissions; ensure you only
grant read/write scopes required (e.g., read for repository contents, limited
write for checks or statuses if used), and avoid granting broad write
permissions or secrets access to forked PRs by keeping GITHUB_TOKEN permissions
minimal.
- Around line 56-62: The Coverage Report step using
ArtiomTr/jest-coverage-report-action@v2 currently sets skip-step: install but
does not ensure prior setup of Node or project dependencies; add a preceding
workflow step to run actions/setup-node (or equivalent) and an npm install/yarn
install step so that the action's test-script (npx jest --coverage --ci) can
run; specifically, ensure the job contains a setup-node step and a dependency
install step before the action named "Coverage Report" (which invokes
test-script and skip-step: install).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9e7536da-8aba-42f8-acbf-f68492540586
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (9)
.github/workflows/deploy.yml.github/workflows/pr-check.yml.husky/commit-msg.husky/pre-commitcommitlint.config.mjspackage.jsonsrc/features/seller/services/seller-conversation.service.spec.tssrc/global/graphql/scalars/date-time.scalar.tstsconfig.json
- npx jest 대신 yarn jest 사용하여 프로젝트 jest 29 설정과 호환 - coverage-report job에 Node.js setup + yarn install 추가 - 워크플로우 최상위에 permissions: contents: read 추가 (최소 권한 원칙)
Coverage report
Test suite run success186 tests passing in 24 suites. Report generated by 🧪jest coverage report action from 0473d3d |
1 participant
PR Summary
개발자 경험(DX) 향상을 위해 husky, commitlint 등 DX 도구를 도입했습니다.
CI 파이프라인을 강화하여 PR 체크, 타입 검사, 린트, 테스트, 빌드 과정을 자동화했습니다.
커밋 메시지 형식을 강제하여 일관된 커밋 기록을 유지하도록 설정했습니다.
Changes
.github/workflows/deploy.yml.github/workflows/pr-check.yml.husky/commit-msg.husky/pre-commitcommitlint.config.mjspackage.jsonsrc/features/seller/services/seller-conversation.service.spec.tssrc/global/graphql/scalars/date-time.scalar.tstsconfig.jsonImpact
Checklist
Dependencies
Summary by CodeRabbit
릴리스 노트
버그 수정
Chores