Fix tracker bar not loading music roll when inserted via automation#97
Open
DJCheesusReal wants to merge 1 commit into
Open
Fix tracker bar not loading music roll when inserted via automation#97DJCheesusReal wants to merge 1 commit into
DJCheesusReal wants to merge 1 commit into
Conversation
When a music roll is inserted into a tracker bar through automation (e.g. hopper/funnel), the sequencer never loads the song because onContentsChanged did not trigger onRollChanged(). This commit: - Calls onRollChanged() from onContentsChanged on the server side - Persists buttonsEnabled in NBT so it survives chunk reloads - Reloads the roll via onRollChanged() when the block entity is read from NBT Fixes CSOS-Team#96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #96
When a music roll is inserted into a tracker bar through automation (hopper/funnel), the sequencer never loads the song and the GUI buttons stay greyed out because \onContentsChanged()\ did not trigger \onRollChanged().
Changes
These are the same changes I described in the issue.