Open
Conversation
…nual all project sync
…d by their own parent
Closed
aHalliday13
reviewed
Sep 10, 2025
Member
aHalliday13
left a comment
aHalliday13
left a comment
There was a problem hiding this comment.
I've left a couple comments, but nothing stands out to me as being majorly flawed. Has this been tested on Erised or Elephant? If so I'd be fine with approving this and deploying.
| return completedJobs; | ||
| } | ||
|
|
||
| auto JobManager::write_streams_to_file(const ::pid_t processID) |
Member
There was a problem hiding this comment.
looks like a random number is being assigned to the log files? maybe it might make more sense to use a timestamp when the log file is generated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #44
Changes from previous PR in sync scheduler:
Add more logging (helps identify problematic entries in mirrors.json)
Add more general exception handling (scheduler will fail gracefully and skip invalid projects)
Update the development config for mirrors.json to reflect new schema for scripts