Repository navigation
DPC-5710: Move DPC portal onto CDAP service module - #620
Merged
Merged
Conversation
jscott-nava
force-pushed
the
jscott/DPC-5710
branch
from
October 2, 2026 22:35
35dcae0 to
54140ac
Compare
jscott-nava
marked this pull request as ready for review
October 2, 2026 22:35
mianava
reviewed
Oct 5, 2026
mianava
left a comment
mianava
left a comment
Contributor
There was a problem hiding this comment.
These changes seem like they're making our work more efficient, shifting to a list from dedicated variables, is that the motivation for restructuring the variables?
Contributor
Author
@mianava This change was made to account for the api and attribution services, both of which expose two ports in their Service Connect configurations. So converting the standalone variables into a list of objects seemed the way to go, even though the portal service itself exposes only one port. |
jscott-nava
force-pushed
the
jscott/DPC-5710
branch
from
October 5, 2026 21:59
54140ac to
4f4520f
Compare
mianava
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-5710
🛠 Changes
This PR contains updates that were required in order to move the DPC portal service onto the CDAP service module. A corresponding PR with DPC portal service changes can be found here.
ℹ️ Context
These changes are part of a larger effort to standardize IAC across the DDIP program by utilizing common modules in the CDAP repository.
🧪 Validation
Please refer to the related
dpc-opsPR for validation details.