Remove implicit use of CRS in code base - #1020

Closed

luseverin wants to merge 68 commits into

feature/remove_implicit_use_crs

Commits on Sep 22, 2024

Add function to test if lat and lon are in geographic coords
luseverin
committed
657b612
Add test for geographic coords in dist_to_coast
luseverin
committed
b594b7f
Add test for geographic coords in coord_on_land
luseverin
committed
e36ded8

Commits on Jan 14, 2025

Merge branch 'develop' into feature/remove_implicit_use_crs
luseverin
committed
b139e8f

Commits on Mar 5, 2025

Merge branch 'develop' into feature/remove_implicit_use_crs
luseverin
committed
c8aac80
Extend allowed extent for geo coords
luseverin
committed
320d0f7

Commits on Mar 6, 2025

Modify allowed extents in geo_coords check function to allow for bounds
luseverin
committed
9ef7323
Include possible wrong lat lon extension in error message
luseverin
committed
f27c4aa
Add check for geo coords in get_country_code
luseverin
committed
df439a5
Add test for geocoords in convert_wgs_to_utm
luseverin
committed
d3aea1e
Update error message in coord_on_land
luseverin
committed
fb3cf7e
Harmonize error messages
luseverin
committed
cf57963
Adapt test get_country_geometries_fail
luseverin
committed
cb1e718
Check for geo coords in match_coordinates
luseverin
committed
2a1f9b1
Add check for lat in get_gridcellarea
luseverin
committed
322a9d3
Modify check geo coords function to please linter
luseverin
committed
60dc067
Add test for geo coords in calc of coriolis param
luseverin
committed
a0e02be
Add tests for check_if_geo_coords function
luseverin
committed
127d9cc

Commits on Apr 8, 2025

Merge branch 'develop' into feature/remove_implicit_use_crs
luseverin
committed
737fcd4
Incorporate suggestions from review 1
luseverin
committed
eca9f77

Commits on May 15, 2025

Start adapating match_coordinates function to other crs
luseverin
committed
99635bf
Add handling of unit in match_centroids
luseverin
committed
a642c04
Rename deg to degrees
luseverin
committed
eea31cb
Add function to infer unit of coordinates
luseverin
committed
35f0f7f
Use infer_unit_coords in match_centroids function
luseverin
committed
782b53d
Add tests for unit_infer and unit-adapted match_coordinates
luseverin
committed
ffee7f8
Make test_tack_land_params compliant with new requirement of geodetic coords
luseverin
committed
61e7b0f
Correct wrong is_geodetic crs attribute
luseverin
committed
ef250c4
Add restriction for haversine with non-degree units
luseverin
committed
bca6e3a
Finish adding test for handling of different units
luseverin
committed
54e2f75
Add test invalid unit for match coords and docstrings
luseverin
committed
63bf8b5
Update docstrings
luseverin
committed
da1c965
Try to fix new linter issues
luseverin
committed
5d53512
Correct error in logger warning
luseverin
committed
54c8565

Commits on Jun 19, 2025

Commits on Jun 27, 2025

Add function to get coordinates from axis of coordinates'crs
luseverin
committed
41b66bb
Update unit names to be consistent with epsg notation and remove unit kw from match_centroids
luseverin
committed
7d1d3f3
Clarify docstring check_if_geo_coords
luseverin
committed
2176402
Make conversion between radians and degrees more consistent
luseverin
committed
8edb184
Remove deprecated infer_unit_coords function
luseverin
committed
91600a9
Update tests
luseverin
committed
f0d8dcc
Force input coords and centroids to have crs attribute in match_centroids
luseverin
committed
d45e55f
Re-harmonize unit names and raise error when crs of centroids or coords is None
luseverin
committed
409ff73
Add missing tests
luseverin
committed
028fa0b
Fix linter issues
luseverin
committed
2da2e2e
Refix linter
luseverin
committed
e2022ba

Commits on Jul 28, 2025

Commits on Jul 30, 2025

Make clearer error message for _nearest_neighbor with non-allowed units
luseverin
committed
16bcc84
Simplify crs check in match_centroids
luseverin
committed
07a4a73
Correct typo and update tests for new error messages in match_centroids
luseverin
committed
f2d49b3
Only warn for check_antimeridian when it is true and add tests
luseverin
committed
0f3de31
Allow for units other than degree km and m by keeping distance threshold in the given unit
luseverin
committed
c67d6da
Update thresholds in test to be consisten with handling of thresholds in non-degree units
luseverin
committed
a260848
Remove mention to calling functions in error message in _nearest_neighbor_haversine

luseverin
and
chahank
authored
2f6bb5e
Remove mention to calling functions in error message in _nearest_neighbor_approx

luseverin
and
chahank
authored
734541a
Update docstrings match_centroids
luseverin
committed
86d8126
update docstrings for match_coordinates
luseverin
committed
faf8666
Update changelog
luseverin
committed
b55b02a

Commits on Aug 5, 2025

Remove confusing comments in code
luseverin
committed
45175c2