develop 기반 GSMSV CD 및 Discord 배포 알림 구축 - #41
Open
exijn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 작업 내용
🔍 리뷰 시 참고사항
developpush는 Repository VariableCD_ENABLED가 정확히true일 때만 배포합니다.workflow_dispatch의 기본dry_run=true는 이미지 빌드만 수행하며 SSH, 서버 배포, GHCR push, Discord 전송을 하지 않습니다.develop가변 태그를 GHCR에 push하고, 서버에서는 readiness 확인 후 app만 갱신합니다.DISCORD_DEPLOY_WEBHOOK_URLSecret에서만 읽고, 로그·URL·환경변수는 전송하지 않도록 마스킹·길이 제한을 적용했습니다.DEPLOY_HOST,DEPLOY_PORT,DEPLOY_USER,DEPLOY_SSH_KEY,DISCORD_DEPLOY_WEBHOOK_URLCD_ENABLED, 선택DEPLOY_PATH(기본/opt/mudda)workflow_dispatchdry-run과 서버 파일·GHCR 접근 권한을 별도로 확인해야 합니다.변경 파일
.github/workflows/deploy-develop.ymlops/deploy/의 배포·알림·마스킹 스크립트와 fixture 테스트docker-compose.prod.yml의APP_IMAGEoverridedocs/GSMSV_CD.md설계·보안
contents: read,packages: write로 제한했습니다.pull_request에서는 실행되지 않으며,pull_request_target과 PAT를 사용하지 않습니다.developpush의 trusted revision만 checkout합니다..env.production을 Actions로 가져오지 않습니다.down -v/prune하지 않습니다.검증 결과
bash -n ops/deploy/*.sh: 통과bash ops/deploy/tests/test.sh: 통과docker compose --env-file .env.production -f docker-compose.prod.yml config --quiet: 통과 (placeholder fixture)git diff --check: 통과./gradlew test: JDK 25/전역 JDK 26 설정 및 Kotlin DSL 호환 오류로 실패; JDK 23 재시도는 Docker/Testcontainers 환경에서 중단됨docker buildx build: Docker Desktop Linux daemon 미기동으로 실행 불가shellcheck,actionlint: 설치되어 있지 않아 실행하지 못함자체 코드 리뷰
제외 범위
✅ 체크리스트
.env.example등) 변경이 필요한 경우 작성 또는 수정했나요?develop)🌏 Deploy, 리뷰어는 지정하지 않음)📎 관련 이슈(선택)