Deprecate unused classes and corresponding tutorials, revise RandomVariable tutorial#677
Deprecate unused classes and corresponding tutorials, revise RandomVariable tutorial#677cdc-mitzimorris merged 34 commits intomainfrom
Conversation
cdc-mitzimorris
requested review from
SamuelBrand1,
damonbayer and
dylanhmorris
as code owners
for more information, see https://pre-commit.ci
|
Note, this PR shouldn't be reviewed until PR #650 has landed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
==========================================
- Coverage 97.58% 97.46% -0.12%
==========================================
Files 55 51 -4
Lines 1697 1540 -157
==========================================
- Hits 1656 1501 -155
+ Misses 41 39 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you for your contribution @cdc-mitzimorris 🚀! Your github-pages is ready for download 👉 here 👈! |
|
@cdc-mitzimorris is this ready for review? |
…to mem_deprecate_classes
|
@dylanhmorris - yes, ready for review. |
# Conflicts: # docs/tutorials/building_multisignal_models.qmd
dylanhmorris
left a comment
dylanhmorris
left a comment
There was a problem hiding this comment.
Thanks @cdc-mitzimorris. A few minor suggestions. Happy for you to implement as you see fit and then merge without re-review.
Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
…to mem_deprecate_classes
cdc-mitzimorris
changed the title
2 participants
Per discussion in issue #645, remove the following unused classes:
Removed corresponding unit tests.
This also requires removing several tutorials as well as changing the Custom Random Variables tutorial. For the latter, I have rewritten it so that it is a general presentation of PyRenew's
RandomVariablemetaclass. As part of this PR, I have also updateddocs/index.md.