feat: add reusable tag selector for Add/Edit Task dialogs #390
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
Hell1213
left a comment
Hell1213
left a comment
There was a problem hiding this comment.
Done with self review , PR adds a reusable tag component that makes tag management easier for users. Instead of typing tags manually , users can now select from existing tags or create new ones through a dropdown. The component is used in both Add Task and Edit Task dialogs, removing code duplication.
Hell1213
changed the title
its-me-abhishek
left a comment
its-me-abhishek
left a comment
There was a problem hiding this comment.
Overall looks good, do checkout the suggestions
| setTasksPerPage(parseInt(storedTasksPerPage, 10)); | ||
| } | ||
| }, [props.email]); | ||
| useEffect(() => { |
There was a problem hiding this comment.
this useEffect could be removed, completely
| @@ -0,0 +1,203 @@ | |||
| import { useState, useRef, useEffect } from 'react'; | |||
There was a problem hiding this comment.
can we move to a more generic name for this? considering it will be used for both Tags, and Annotations
| handleNewTagCreate(); | ||
| } | ||
| } | ||
| // Do nothing if search is empty |
There was a problem hiding this comment.
do remove the comment
| } | ||
| }; | ||
|
|
||
| const handleKeyDown = (e: React.KeyboardEvent) => { |
There was a problem hiding this comment.
maybe extract this and other functions to the utils file
|
|
||
| expect(screen.queryByText('tag2')).not.toBeInTheDocument(); | ||
| await waitFor(() => { | ||
| // Check that tag1 is not in the selected tags badges area |
There was a problem hiding this comment.
kindly remove the comment
There was a problem hiding this comment.
and other such comments
| @@ -0,0 +1,556 @@ | |||
| import { render, screen, fireEvent, waitFor } from '@testing-library/react'; | |||
There was a problem hiding this comment.
tests would need to be updated, upon changing the file name
|
sure @its-me-abhishek , i have implemented all changes as requested will push soon . |
Hell1213
force-pushed
the
fix/issue-210-reusable-tags
branch
from
cd58387 to
4937543
Compare
2 participants
Replaced manual tag input with a dropdown selector to fix typos and inconsistent tagging.
Changes:
Added new TagMultiSelect component with dropdown for tag selection
Replaced manual tag input in Add Task dialog with TagMultiSelect
Replaced manual tag input in Edit Task dialog with TagMultiSelect
Save/cancel buttons now appear inline with selected tags
Fixes: #210
Checklist
Additional Notes
The new component makes tag management easier:
Click dropdown to see all existing tags
Search or create new tags by typing
Press Enter or create tag to add a tag
Click X on tag badges to remove them
Save/cancel buttons show up next to the tags
Demo
Screencast.from.2026-01-10.14-38-35.mp4