-
Notifications
You must be signed in to change notification settings - Fork 526
fix(cli): improve error message when no input file is provided #2022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 2028754...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 2028754...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
|
Hi, thanks for the CI feedback. The failing Linux and Windows CI jobs appear to be due to test expectations that rely on the previous CLI error message when no input file is provided. Since this PR updates that message, I believe the related CLI tests need to be updated accordingly. I’m currently checking the failing test cases to align the expected output with the new behavior. Please let me know if there is a preferred location or approach for updating these tests. Thanks for your time and guidance. |
|
The right approach would be to improve the argument parser in Rust - not to do this in C which we are deprecating. |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
{pull request content here}