[FIX] rust: add defensive length check to validate_cc_pair#2015
Merged
cfsmp3 merged 4 commits intoCCExtractor:masterfrom Jan 18, 2026
Merged
[FIX] rust: add defensive length check to validate_cc_pair#2015cfsmp3 merged 4 commits intoCCExtractor:masterfrom
cfsmp3 merged 4 commits intoCCExtractor:masterfrom
Conversation
Contributor
|
The cd src/rust && cargo fmtThis will fix the missing spaces before
Once the formatting is fixed, this should be ready to merge. |
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 9d921de...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit b8019bd...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Summary
Adds a defensive guard to
validate_cc_pairto ensure the function onlyprocesses CC blocks of the expected length (3 bytes).
This prevents potential out-of-bounds access if the function is ever
called with malformed input. Behavior for valid CC blocks is unchanged.
Details
falseearly when the CC block slice length is not exactly 3