feat: add release dates and descriptions to collections#269
Open
TowyTowy wants to merge 1 commit into
Open
Conversation
Adds "release_date" (ISO 8601) and "description" fields to every entry in collections.json. Release dates are curated in utils/collectionReleaseDates.json, keyed by collection id; descriptions are pulled from the official csgo_english "set_description" token where Valve provides one (null otherwise). Closes ByMykel#196. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Bad PR, not really evidence based |
Author
|
Happy to correct any entry that's wrong — which dates do you see as not evidence based? The sourcing is described in the PR body: the 38 case-linked collections reuse the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #196.
Adds two fields to every entry in
collections.json:release_date— ISO 8601 (YYYY-MM-DD), curated inutils/collectionReleaseDates.jsonkeyed by collectionid(same pattern asutils/specialNotes.json).description— the officialset_descriptiongame string via$t(), ornullwhen Valve provides none.Why curated: release dates aren't present in
items_game/csgo_english(as noted in the issue), so they're maintained in a JSON map. Where a collection is tied to a case, the value matches the case'sfirst_sale_datealready published incrates.json; a handful of 2013–2014 cases whosefirst_sale_dateis a bulk market-enable artifact (the three Arms Deal sets all read2013-09-20, the three eSports sets all read2014-07-09) were corrected to their real release dates via patch notes; the rest are sourced from CS wiki / patch notes.Descriptions are only shipped when Valve supplies an official string (currently 8 collections, e.g. the Bravo/Alpha grant collections and the charm/sticker capsules) and auto-populate as more are localized — no hand-written text.
Acceptance contract
nullwhere unknown. Purely additive — no existing field changed (regen diff is +212/-0 foren).null— no reliable public date).Lower-confidence dates, flagged for review: 2018 Nuke/Inferno (
2018-09-01, approximated to the FACEIT London major window), Cache (2014-08-08), Bank (2013-11-27), Genesis (2025-09-17), Dead Hand (2026-03-12vs SteamDB's "11 March 2026"), and the Oct 2025 sticker/charm sets (2025-10-01, though the in-game description text says "September 2025"). Happy to adjust any of these.Data files are left for the update bot to regenerate across all languages.