Conversation
There was a problem hiding this comment.
Sorry @ArgoZhang, your pull request is larger than the review limit of 150000 diff characters
There was a problem hiding this comment.
Pull request overview
This PR bumps the UniverSheet component version from 10.0.7 to 10.0.9. The changes consolidate the library's asset loading strategy by removing numerous locale and component-specific files in favor of a single bundled approach, and improves the loading UI experience with a more polished backdrop/loading indicator.
Changes:
- Updated version from 10.0.7 to 10.0.9 in the .csproj file
- Removed multiple locale files and component-specific JavaScript/CSS bundles in favor of using a consolidated univer-bundle.js
- Refactored loading UI with new CSS file, improved loading state management, and added ShowLoading parameter
- Added firstPush tracking to data-service for better initial load handling
Reviewed changes
Copilot reviewed 83 out of 133 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| BootstrapBlazor.UniverSheet.csproj | Version bump from 10.0.7 to 10.0.9 |
| univer.js | Simplified asset loading by removing granular script/link loading in favor of single bundle |
| UniverSheet.razor.js | Enhanced loading backdrop management with firstPush flag and timing control |
| UniverSheet.razor.cs | Added ShowLoading parameter (default true) for controlling loading UI visibility |
| UniverSheet.razor | Refactored loading backdrop HTML structure with conditional rendering |
| data-service.js | Added firstPush flag tracking to distinguish initial data push |
| plugin.js | Removed Chinese comment |
| css/univer-sheet.bundle.css | New consolidated CSS file with improved loading backdrop styling |
| wwwroot/univer/* | Removed numerous locale files, component-specific bundles, and React libraries (replaced by single bundle) |
Comments suppressed due to low confidence (3)
src/components/BootstrapBlazor.UniverSheet/wwwroot/univer.js:18
- Avoid automated semicolon insertion (90% of all statements in the enclosing function have an explicit semicolon).
const lang = sheet.lang.replace('-', '')
src/components/BootstrapBlazor.UniverSheet/wwwroot/univer.js:19
- Avoid automated semicolon insertion (90% of all statements in the enclosing function have an explicit semicolon).
const langStr = lang.charAt(0).toUpperCase() + lang.slice(1)
src/components/BootstrapBlazor.UniverSheet/wwwroot/univer.js:103
- Avoid automated semicolon insertion (90% of all statements in the enclosing function have an explicit semicolon).
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| sheet.lang = sheet.lang ?? 'en-US'; | ||
| await loadAssets(sheet.lang); | ||
| const { el } = sheet; | ||
| const { LocaleType, merge } = UniverCore; |
There was a problem hiding this comment.
Unused variable LocaleType.
| const { LocaleType, merge } = UniverCore; | |
| const { merge } = UniverCore; |
Link issues
fixes #909
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge