Capture direct native frames and verify both installed rendering paths - #168
Draft
proggeramlug wants to merge 1 commit into
Draft
Capture direct native frames and verify both installed rendering paths#168proggeramlug wants to merge 1 commit into
proggeramlug wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A native game using
setDirect2DMode(true)renders and exits without producing its queued PNG. The direct frame path now services output capture after drawing through the existing framebuffer readback implementation. Render-target-only frames keep the output request pending, and ordinary frames retain their submission behavior.Extract the direct frame method into its own module and extend the installed-package gate to compile and run the same Jolt physics fixture through both scene and direct-2D rendering. Add a renderer regression for uncaptured frames, capture deferral across a smaller render texture and successive captures with different exact pixels.
Local validation: all four installed fixture captures match all 16,384 expected pixels on Radeon DX12 and Vulkan. Each backend also passes all five render-target tests and all 93 image goldens, with four existing ignored cases. Contracts, formatting, strict Clippy, WASM compilation and blank/physics-failure image controls pass. Image baselines and thresholds are unchanged. Original missing-capture evidence and the WASM guard correction are retained.
Stacked on #167. Hosted Tests run 34559712338 passes all 22 jobs, including both installed rendering modes with all expected pixels, native engine build and all 20 example links. Hosted source trees match the PR head. This qualifies native headless capture with the validated Perry 0.5.1220 runtime profile; local DX12 uses SDK compiler DLLs on PATH. Visible presentation, browser startup/capture, packaged DXC and the complete starter/lifecycle remain separate. Relates to #140, #142 and #145.
Published report and evidence retain the original missing-capture and WASM failures, exact final source, fresh installed scene/direct-2D checks and all final hosted results. ZIP SHA-256:
f0f2a03b41d1f926c900a9901831f2a96a5311cab55f22c63e60f0b7f542dd34.