Skip to content

Require native links for every canonical example - #161

Draft
proggeramlug wants to merge 1 commit into
codex/windows-examples-cifrom
codex/windows-example-gate
Draft

Require native links for every canonical example#161
proggeramlug wants to merge 1 commit into
codex/windows-examples-cifrom
codex/windows-example-gate

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

The previous example check only generated object code, so missing native symbols escaped CI. Require fresh native executables, retain their hashes and logs, and continue collecting failures after a compiler error or timeout. The quick lane links Pong; the full and hardware lanes link all canonical examples. Windows PR CI runs the full component after its native engine build and requires its execution summary.

Perry 0.5.1220 supplies the embedded-view API, but the official Windows bundle has unresolved standard-library HTTP symbols. Per-app source rebuilding also exposes Rust COMDAT link collisions in five examples. The pinned setup tool verifies the release ZIP and source commit, builds the matching libraries with a common unwind/feature profile, and records their hashes. This profile links all 20 examples without compiler-source patches.

Validation: all 20 native links pass locally; three false-success/failure-collection regressions, the full quality-contract component, repository contracts, and git diff --check pass. Hosted Tests run 34544031931 also passes the native engine build and all 20 example links. Its merge checkout has the same tree as tested head 59244b9. Linking does not qualify actual startup or installed-package behavior.

Stacked on #160. The Windows shared suite still has two required DX12 GPU failures (486 passed, two failed, one ignored at this head). The earlier #160 access violation remains unresolved; this completed run does not prove a crash fix. This change advances #140/#142/#74 and does not close their full acceptance criteria. See the report.

Published evidence retains successful native build hashes, failed toolchain profiles, CI logs and source/toolchain receipts. ZIP SHA-256: 2ebcb258a72e473723331dcd9fbaad1781b36d0ea70b0e95a3bcfd90fcf0a9b9.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant