Require native links for every canonical example - #161
Draft
proggeramlug wants to merge 1 commit into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous example check only generated object code, so missing native symbols escaped CI. Require fresh native executables, retain their hashes and logs, and continue collecting failures after a compiler error or timeout. The quick lane links Pong; the full and hardware lanes link all canonical examples. Windows PR CI runs the full component after its native engine build and requires its execution summary.
Perry 0.5.1220 supplies the embedded-view API, but the official Windows bundle has unresolved standard-library HTTP symbols. Per-app source rebuilding also exposes Rust COMDAT link collisions in five examples. The pinned setup tool verifies the release ZIP and source commit, builds the matching libraries with a common unwind/feature profile, and records their hashes. This profile links all 20 examples without compiler-source patches.
Validation: all 20 native links pass locally; three false-success/failure-collection regressions, the full quality-contract component, repository contracts, and
git diff --checkpass. Hosted Tests run 34544031931 also passes the native engine build and all 20 example links. Its merge checkout has the same tree as tested head59244b9. Linking does not qualify actual startup or installed-package behavior.Stacked on #160. The Windows shared suite still has two required DX12 GPU failures (486 passed, two failed, one ignored at this head). The earlier #160 access violation remains unresolved; this completed run does not prove a crash fix. This change advances #140/#142/#74 and does not close their full acceptance criteria. See the report.
Published evidence retains successful native build hashes, failed toolchain profiles, CI logs and source/toolchain receipts. ZIP SHA-256:
2ebcb258a72e473723331dcd9fbaad1781b36d0ea70b0e95a3bcfd90fcf0a9b9.