Closed
Conversation
Markeljan
force-pushed
the
cleanup-dev-commands-apply-linting
branch
from
63f6562 to
d6d1afb
Compare
Markeljan
requested review from
GAllen98,
Jxnis,
SurgeCode,
bh2smith,
microchipgnu,
rubenmarcus and
sainthiago
bh2smith
reviewed
Mar 26, 2025
bh2smith
left a comment
bh2smith
left a comment
There was a problem hiding this comment.
All good except eslint appears to have been removed from the scripts.
One suggestion I usually go for is lint & format commands combining both eslint & prettier something like:
"lint": "eslint src/ && prettier --check '**/*.{js,jsx,ts,tsx}'",
"fmt": "eslint src/ --fix && prettier --write '**/*.{js,jsx,ts,tsx}'"
Comment on lines
-10
to
-11
| "lint": "eslint src --ext .ts,tsx,js,jsx", | ||
| "lint:types": "tsc --noEmit", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix scripts, apply prettier lint script following basic prettier config in
package.json