temp: add WASM integration for DOT #8074
Draft
+4,684
−2,165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcovar
force-pushed
the
BTC-0.dot-wasm
branch
2 times, most recently
from
8f026fb to
93666ed
Compare
Add comprehensive byte-for-byte comparison tests between legacy (txwrapper-polkadot) and WASM (@bitgo/wasm-dot) builders: - Transfer transactions (transfer, transferKeepAlive) - Staking transactions (bond, unbond, withdrawUnbonded, chill) - Proxy transactions (addProxy with Any/Staking types) - Batch transactions (atomic batchAll, non-atomic batch) All tests use strict assertions to verify WASM produces identical call data bytes as the legacy implementation. BTC-0 TICKET: BTC-0
Add explainTransactionFromHex as the single source of truth for parsing DOT transactions from serialized bytes using the WASM parser. This replaces intent-based parsing with a bytes-only approach. - Add @bitgo/wasm-dot dependency - Create wasmParser.ts with explainTransactionFromHex function - Export DotWasmExplanation type and function from lib/index.ts TICKET: BTC-0
TICKET: BTC-0
Remove ~850 lines of unused Solana-inspired instruction mapping code that was never integrated. DOT uses extrinsic calls (pallet methods), not instructions. The actual WASM parser (explainTransactionFromHex in wasmParser.ts) supersedes this pattern. Deleted files: - src/lib/wasm/wasmInstructionMapper.ts - src/lib/wasm/transaction.ts - src/lib/wasm/index.ts - test/unit/wasmTransaction.ts BTC-0 TICKET: BTC-0
- Delete wasmBuilderComparison.ts (scaffolding with console.log exploration) - Simplify wasmBuilderByteComparison.ts to compare full serialized hex directly (toBroadcastFormat vs toHex) instead of extracting call data subsets that hid envelope differences - Update wasm-dot tgz to latest build - Fix duplicate @bitgo/wasm-dot entry in package.json The comparison tests now correctly expose that legacy toBroadcastFormat() returns signing payloads for unsigned txs while WASM toHex() returns actual unsigned extrinsics — these are different formats by design. BTC-0 TICKET: BTC-0
… payloads Compare WASM signablePayload() against legacy toBroadcastFormat() for unsigned transactions. Accounts for format difference: txwrapper encodes call as Bytes (with compact-length prefix), subxt encodes as raw Call. All 11 comparison tests now pass (191 passing, 0 failing). BTC-0 TICKET: BTC-0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BTC-0
TICKET: BTC-0