feat(sdk-coin-sol): upgrade @solana/spl-token from 0.3.1 to 0.4.9#8072
Open
feat(sdk-coin-sol): upgrade @solana/spl-token from 0.3.1 to 0.4.9#8072
Conversation
## Why this upgrade is needed The current @solana/spl-token@0.3.1 has a broken ESM build - the .mjs files have incorrect import paths that reference directories instead of files (e.g., `./memoTransfer.mjs` instead of `./memoTransfer/index.mjs`). This blocks webpack browser bundles from using ESM resolution for @bitgo/sdk-coin-sol, which is required for @bitgo/wasm-solana support (WASM modules need ESM for proper async initialization in browsers). ## What changed in 0.4.x 1. Fixed ESM imports - uses .js files with "type": "module" and correct paths like `./memoTransfer/index.js` 2. Removed SYSVAR_RENT_PUBKEY from Associated Token Account instructions. This is a valid Solana protocol change - the rent sysvar was deprecated because the Solana runtime now provides rent information automatically. Transactions are now more efficient (6 accounts instead of 7). ## Test fixture updates 27 test fixtures in test/resources/sol.ts were regenerated to reflect the new transaction serialization. The transactions are functionally equivalent and valid on-chain. Ticket: BTC-3009
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this upgrade is needed
The current @solana/spl-token@0.3.1 has a broken ESM build - the .mjs files have incorrect import paths that reference directories instead of files (e.g.,
./memoTransfer.mjsinstead of./memoTransfer/index.mjs).This blocks webpack browser bundles from using ESM resolution for @bitgo/sdk-coin-sol, which is required for @bitgo/wasm-solana support (WASM modules need ESM for proper async initialization in browsers).
What changed in 0.4.x
Fixed ESM imports - uses .js files with "type": "module" and correct paths like
./memoTransfer/index.jsRemoved SYSVAR_RENT_PUBKEY from Associated Token Account instructions. This is a valid Solana protocol change - the rent sysvar was deprecated because the Solana runtime now provides rent information automatically. Transactions are now more efficient (6 accounts instead of 7).
Test fixture updates
27 test fixtures in test/resources/sol.ts were regenerated to reflect the new transaction serialization. The transactions are functionally equivalent and valid on-chain.
Ticket: BTC-3009