Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions modules/sdk-coin-flrp/src/flrp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@ export class Flrp extends BaseCoin {
this.validateImportTx(explainedTx.inputs, params.txParams);
}
break;
case TransactionType.AddPermissionlessDelegator:
// Validate delegation transaction against both txParams and explainedTx
this.validateDelegationTx(params.txParams, explainedTx);
break;
default:
throw new Error('Tx type is not supported yet');
}
Expand Down Expand Up @@ -166,6 +170,52 @@ export class Flrp extends BaseCoin {
}
}

/**
* Validate AddPermissionlessDelegator transaction parameters.
* Validates both expected txParams and the parsed explainedTx for consistency.
*
* @param {FlrpTransactionParams} txParams - Expected transaction parameters
* @param {FlrpLib.TransactionExplanation} explainedTx - Parsed transaction explanation
*/
validateDelegationTx(txParams: FlrpTransactionParams, explainedTx: FlrpLib.TransactionExplanation): void {
if (!txParams.stakingOptions) {
throw new Error('Delegation transaction requires stakingOptions');
}

const { nodeID, amount, durationSeconds, rewardAddress } = txParams.stakingOptions;

if (!nodeID) {
throw new Error('Delegation transaction requires nodeID');
}

if (!amount) {
throw new Error('Delegation transaction requires amount');
}

if (!durationSeconds) {
throw new Error('Delegation transaction requires durationSeconds');
}

if (!rewardAddress) {
throw new Error('Delegation transaction requires rewardAddress');
}

// Validate nodeID format using utility method
if (!utils.isValidNodeID(nodeID)) {
throw new Error(`Invalid nodeID format: ${nodeID}`);
}

// Validate that the parsed transaction's output amount matches the expected staking amount
// The outputAmount in explainedTx represents the total stake amount in the transaction
if (explainedTx.outputAmount) {
const expectedAmount = new BigNumber(amount);
const actualAmount = new BigNumber(explainedTx.outputAmount);
if (!expectedAmount.isEqualTo(actualAmount)) {
throw new Error(`Delegation amount mismatch: expected ${amount}, transaction has ${explainedTx.outputAmount}`);
}
}
}

private getBuilder(): FlrpLib.TransactionBuilderFactory {
return new FlrpLib.TransactionBuilderFactory(coins.get(this.getChain()));
}
Expand Down
21 changes: 19 additions & 2 deletions modules/sdk-coin-flrp/src/lib/iface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,20 +79,37 @@ export type Tx =
| evmSerial.ExportTx
| evmSerial.ImportTx
| pvmSerial.ExportTx
| pvmSerial.ImportTx;
| pvmSerial.ImportTx
| pvmSerial.AddPermissionlessDelegatorTx;

export type SerializedTx = evmSerial.ExportTx | evmSerial.ImportTx | pvmSerial.ExportTx | pvmSerial.ImportTx;
export type SerializedTx =
| evmSerial.ExportTx
| evmSerial.ImportTx
| pvmSerial.ExportTx
| pvmSerial.ImportTx
| pvmSerial.AddPermissionlessDelegatorTx;
export type BaseTx = pvmSerial.BaseTx;
export type Output = TransferableOutput;
export interface FlrpVerifyTransactionOptions extends VerifyTransactionOptions {
txParams: FlrpTransactionParams;
}

/**
* Staking options for AddPermissionlessDelegator transactions
*/
export interface FlrpStakingOptions {
nodeID: string;
amount: string | number;
durationSeconds: string | number;
rewardAddress: string;
}

export interface FlrpTransactionParams extends TransactionParams {
type: string;
locktime?: number;
unspents?: string[];
sourceChain?: string;
stakingOptions?: FlrpStakingOptions;
}

export interface FlrpEntry extends Entry {
Expand Down
1 change: 1 addition & 0 deletions modules/sdk-coin-flrp/src/lib/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ export { AtomicTransactionBuilder } from './atomicTransactionBuilder';
export { AtomicInCTransactionBuilder } from './atomicInCTransactionBuilder';
export { ImportInCTxBuilder } from './ImportInCTxBuilder';
export { ImportInPTxBuilder } from './ImportInPTxBuilder';
export { PermissionlessDelegatorTxBuilder } from './permissionlessDelegatorTxBuilder';
Loading