Guard U2F workflows to prevent overlapping HAL borrows#1846
Draft
Guard U2F workflows to prevent overlapping HAL borrows#1846
Conversation
Guard U2F unlock/confirm spawns with a single in-progress flag so only one workflow future can run at a time. This prevents concurrent mutable access to the shared global HAL from detached executor tasks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
WORKFLOW_IN_PROGRESS: AtomicBoolinsrc/rust/bitbox02-rust-c/src/u2f_c_api.rsand usecompare_exchangeat the start ofrust_workflow_spawn_unlockandrust_workflow_spawn_confirmto reject new spawns while a workflow is active, and clear the flag when the async future finishes.Testing
cd src/rust && cargo fmt(failed:rustfmt/cargo-fmtnot installed),./scripts/docker_exec.sh make -j run-rust-unit-tests(failed:dockernot available), andcd src/rust && cargo test -p bitbox02-rust-c --no-run(failed:bindgennot in PATH); no unit tests could be executed in this environment but the change is limited and compiles in-tree where toolchain prerequisites are met.Codex Task