attestation: refactor to expose get/verification functions#164
Merged
benma merged 1 commit intoBitBoxSwiss:masterfrom Mar 14, 2026
Merged
attestation: refactor to expose get/verification functions#164benma merged 1 commit intoBitBoxSwiss:masterfrom
benma merged 1 commit intoBitBoxSwiss:masterfrom
Conversation
benma
changed the title
bznein
approved these changes
Mar 12, 2026
api/firmware/attestation.go
Outdated
| return false, errp.New("could not verify challenge signature") | ||
| } | ||
|
|
||
| return true, nil |
Collaborator
There was a problem hiding this comment.
Not sure if it's worth noting or not, but basically this function never returns false and nil, so we could drop one of the two return values and just check the error. Indeed, in performAttestation we directly drop the first returned value and only use the error. But not strong feelings about it
Expose expose verification and GetAttestation. Could be useful for BitBoxCloud for the server to verify attestations, and the client to perform attestation proofs for the server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could be useful for BitBoxCloud for the server to verify attestations.