Skip to content

Frontend swap flip accounts#3904

Merged
thisconnect merged 4 commits intoBitBoxSwiss:staging-swapfrom
thisconnect:frontend-swap-flip-accounts
Mar 3, 2026
Merged

Frontend swap flip accounts#3904
thisconnect merged 4 commits intoBitBoxSwiss:staging-swapfrom
thisconnect:frontend-swap-flip-accounts

Conversation

@thisconnect
Copy link
Collaborator

Before asking for reviews, here is a check list of the most common things you might need to consider:

  • updating the Changelog
  • writing unit tests
  • checking if your changes affect other coins or tokens in unintended ways
  • testing on multiple environments (Qt, Android, ...)
  • having an AI review your changes

Activate flip accounts button in case both sell and buy account
are configured.
In case user wants to flip the buy and sell accounts the flip
button should change the two dropdowns.

Ideally the total value that is received would stay the same but
that should be checked later once the api is integrated.
Last commit added flipping account logic, but the unit of the input
field of input-with-account-selector did not update.
@thisconnect thisconnect requested a review from bznein March 2, 2026 15:42
Copy link
Collaborator

@bznein bznein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK but saw in real time on Eni's laptop :)

@thisconnect thisconnect merged commit b2a1d53 into BitBoxSwiss:staging-swap Mar 3, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants