frontend: refactor back navigation for ios and android#3901
Draft
sutterseba wants to merge 1 commit intoBitBoxSwiss:masterfrom
Draft
frontend: refactor back navigation for ios and android#3901sutterseba wants to merge 1 commit intoBitBoxSwiss:masterfrom
sutterseba wants to merge 1 commit intoBitBoxSwiss:masterfrom
Conversation
sutterseba
force-pushed
the
refactor-back-navigation
branch
from
655c50d to
a32a87e
Compare
Introduces a centralized back policy in BackNavigationContext that drives iOS swipe and Android back via a logical in-app stack instead of raw WebView history. Backward navigation (i.e. swiping or pressing the back button) should only work in certain scenarios, e.g.: - If there is an UI element to navigate back or close - If there is a clear layered menu structure (e.g. individual account) It should explicitly not work work in other scenarios, e.g.: - Switching between tabs - Old history items (e.g. when user clicks "More" > "Settings" > "Manage accounts" > "Portfolio", swiping back should not bring them to "Manage accounts" again)
sutterseba
force-pushed
the
refactor-back-navigation
branch
from
a32a87e to
3818395
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a centralized back policy in BackNavigationContext that drives iOS swipe and Android back via a logical in-app stack instead of raw WebView history.
Backward navigation (i.e. swiping or pressing the back button) should only work in certain scenarios, e.g.:
It should explicitly not work work in other scenarios, e.g.: