Fix bf16/fp32 dtype mismatches in binder_design confidence path - #371
Open
Spongeorge wants to merge 1 commit into
Open
Fix bf16/fp32 dtype mismatches in binder_design confidence path#371Spongeorge wants to merge 1 commit into
Spongeorge wants to merge 1 commit into
Conversation
folding with `calculate_confidence=True` crashes because the confidence head runs fp32 while the trunk feeds it bf16; happens in compiled trimul addmm, the head's layernorm, and numpy conversion of outputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folding with
calculate_confidence=Truecrashes because the confidence head runs fp32 while the trunk feeds it bf16; happens in compiled trimul addmm, the head's layernorm, and numpy conversion of outputs.