fix(macOS): bind JIT QA launches to reviewed cloud isolation receipts - #12811
Merged
Conversation
Route the reserved omi-jit-qa bundle through an atomic cloud-qa endpoint pair backed by a deployment receipt. Validate isolated service identity, revisions, image digests, source SHA, and dependency-vector presence before launching. Failure-Class: none
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The reserved
omi-jit-qalauncher could route only to local or shared development endpoints. A cloud QA launch therefore had no atomic way to pair the isolated Python and desktop services, and an endpoint-shaped environment override could be mistaken for a reviewed deployment.Change
Add a
cloud-qatuple backed by a reviewed deployment receipt. The launcher requires both QA Cloud Run URLs, validates the dev project, namedjit-qaFirestore database, fixed services, gateway URL, revisions, image digests, source SHA, and dependency vector, rejects shared and production hosts, and binds Python/auth tobackend-jit-qawhile the child desktop agent usesdesktop-backend-jit-qa. Use one producer-shaped receipt fixture and cover both supported Cloud Run URL forms, missing review, wrong database, mismatched hosts, and malformed receipts.Validation
bash -n desktop/macos/scripts/jit-qa-target.sh desktop/macos/scripts/omi-jit-qa desktop/macos/tests/test-jit-qa-target.shbash desktop/macos/tests/test-jit-qa-target.shshellcheck desktop/macos/scripts/jit-qa-target.sh desktop/macos/scripts/omi-jit-qamake preflightFailure-Class: none