Add method get_time_array to the File class#186
Merged
rocco8773 merged 28 commits intoBaPSF:masterfrom Apr 1, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #186 +/- ##
==========================================
+ Coverage 98.71% 98.86% +0.14%
==========================================
Files 54 54
Lines 3729 3772 +43
Branches 717 727 +10
==========================================
+ Hits 3681 3729 +48
+ Misses 43 39 -4
+ Partials 5 4 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…generate the get_digitizer_specs()
…set_name() instead of get_adc_info()
…so we do NOT modify the entry in the configs dict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds the
get_time_array()method to thebapsflibFileclass. This method will take either anHDFReadDataobject generated byFile.read_data()or a digitizer information dictionary generated byFile.get_digitizer_specs()to build the time array or retrieve the time array from the appropriate dataset.The time array will be constructing if the digitizer meta-data contains the digitizing
"clock rate". If the time series is stored in a dataset indicated by the"time_dset_path"meta-data, then that dataset will be directly retrieved.get_time_array()on theFileclass.get_digitizer_specs()to retrieve the information dictionary fromconstruct_dataset_name()instead ofget_adc_info(). This maintains consistency with theinfodict generated byHDFReadData.construct_dataset_name, where the mappingconfigsdictionary would be modified if that returned dictionary was modified.