Skip to content

mgmt eng, keep premium samples in place#48226

Draft
XiaofeiCao wants to merge 2 commits intoAzure:mainfrom
XiaofeiCao:mgmt_eng_keep_premium_samples_in_place
Draft

mgmt eng, keep premium samples in place#48226
XiaofeiCao wants to merge 2 commits intoAzure:mainfrom
XiaofeiCao:mgmt_eng_keep_premium_samples_in_place

Conversation

@XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented Mar 4, 2026

Description

This PR does:

  1. Remove logic to copy premium samples from individual packages to sdk/resourcemanager/azure-resourcemanager
  2. Remove logic to add unreleased entry in version_client.txt and use unreleased version in azure-resourcemanager

The changes include both Swagger and TypeSpec generation. Tested locally for both.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Mar 4, 2026
github-merge-queue bot pushed a commit to microsoft/typespec that referenced this pull request Mar 6, 2026
- emitter part for
Azure/azure-sdk-for-java#47621
- autorest PR: Azure/autorest.java#3298
- sdk repo PR: Azure/azure-sdk-for-java#48226
- sync SDK PR looks good:
Azure/azure-sdk-for-java#48179

## Summary

Replace `AzureResourceManager` with SDK-specific `XXManager` as the
entry point in Fluent Premium samples.

Previously, premium samples were generated with `AzureResourceManager`
as the entry type and then moved to
`sdk/resourcemanager/azure-resourcemanager/samples` by the downstream
`generate.py` script. This change makes premium samples use the
corresponding `XXManager` (e.g., `ComputeManager`, `StorageManager`)
directly, so samples can stay in their own SDK location.

### Before vs After

```java
// Before: premium sample used AzureResourceManager
void sampleMethod(com.azure.resourcemanager.AzureResourceManager azure) {
    azure.storageAccounts().manager().serviceClient().getStorageAccounts().list();
}

// After: premium sample uses SDK-specific manager
void sampleMethod(com.azure.resourcemanager.storage.StorageManager manager) {
    manager.serviceClient().getStorageAccounts().list();
}
```

Will update `generate.py` when this got shipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant