[AKS] `az aks install-cli`: Add optional native Azure skills installation by gambtho · Pull Request #34101 · Azure/azure-cli

Tom Gamble (gambtho) · 2026-09-19T02:06:27Z

🤖 PR Validation — ⚠️ Review suggested

Breaking Changes	Tests
⚠️ None	️✔️ 130/130

⚠️AzureCLI-BreakingChangeTest

⚠️acs

rule cmd_name rule_message suggest_message

⚠️ 1006 - ParaAdd aks install-cli cmd aks install-cli added parameter install_azure_skills

⚠️ 1006 - ParaAdd aks install-cli cmd aks install-cli added parameter skills_agents

Related command

az aks install-cli

Description

Offer native, opt-in installation of Microsoft Azure skills after the existing kubectl and kubelogin installation succeeds.

In an interactive, non-sudo session, offer installation with a default of No. Detect Claude Code, Codex, GitHub Copilot, and Pi; preselect detected agents and allow numbered selection/deselection.
Show user-level destinations and scope before final confirmation, including under --only-show-errors. Use native Knack prompts and typed Azure CLI errors.
Add --install-azure-skills true|false and --skills-agents. Explicit installation requires targets and bypasses prompts; omitted noninteractive execution and explicit false preserve binary-only behavior.
Retrieve the latest stable microsoft/azure-skills release by resolved commit, install complete skill trees/resources and license notices, and report provenance. Install no MCP configuration, hooks, or agent applications; add no runtime dependencies.
Reuse --gh-token for trusted GitHub metadata requests only. Bound transport/download/extraction, reject unsafe archive paths and destination indirection, and stage before publication.
First-install-only, not an updater: skip identical existing directories; preserve/report differing content. New skills can be added, but retries across releases can leave mixed versions. Do not overwrite user modifications or automatically remove skills.
Preserve completed binary installations on optional failure. Explicit skills failures return nonzero with partial-result and recovery guidance.

Codex uses the shared ~/.agents/skills directory, so deselecting another agent does not prevent that agent from discovering shared skills. Selection controls installation destinations, not agent enablement.

Testing Guide

After running the CLI from this branch:

# Existing command: offers skills only in an eligible interactive session.
az aks install-cli

# Explicit binary-only behavior.
az aks install-cli --install-azure-skills false

# Unattended opt-in for selected agents.
az aks install-cli --install-azure-skills true --skills-agents claude-code codex github-copilot pi

Run unprivileged when testing skills installation. If default binary destinations need elevated access, use user-writable --install-location and --kubelogin-install-location paths, including the binary filenames. A skills acceptance installs into the selected user-level directories; automated verification instead used temporary destinations.

Verification performed on Linux/Python 3.14 with worktree source overlays:

test_azure_skills, test_custom, and test_validators: 402 tests run, 400 passed, 2 known skips.
Ruff E/F checks using repository ignores, targeted pycodestyle E128 checks on all six changed Python files, and git diff --check: passed.
Live v1.2.49 (abaf74ac8f62fbe9f83d7ccb2bd991dca929a4da) smoke after the conformance changes: 28 installations, then 28 identical no-ops; all 926 original payload files byte-matched; notices retained; temporary state removed.
Real-console regression coverage exercises native selection/consent under both quiet-mode configurations. Earlier implementation validation also exercised seven pseudo-terminal scenarios.
Polish and independent task/whole-branch reviews completed. CodeRabbit CLI reviewed the full committed diff twice; its minor continuation-indentation findings were corrected and verified. The follow-up review included the repository command/error guidelines.

The two skips are native Windows junction coverage and an existing kubelogin custom-source test. Existing ResourceWarnings/datetime deprecations remain unchanged. Native Windows/macOS, Python 3.10 runtime, full azdev ACS/style/linter gates, and actual agent/MCP workflows have not been exercised locally; CI/platform review remains necessary.

History Notes

[AKS] az aks install-cli: Add optional native Azure skills installation for coding agents

The PR title and description follow the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.

azure-pipelines · 2026-09-19T02:06:37Z

Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

Copilot review overview

🔵 Needs a closer look

The changes require final human review because they are too complex or risky for automated approval.

Review effort: Lite
Findings: None

What changed in this PR

Adds opt-in native Azure skills installation to az aks install-cli, preserving existing binary behavior while supporting agent detection, safe downloads, staging, and non-overwriting publication.

Changes:

Adds interactive and explicit skills-installation modes with agent selection.
Implements bounded GitHub release retrieval, archive validation, and secure publication.
Adds extensive tests, help text, and design/implementation documentation.

File	Description
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py	Updated as part of this pull request.
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_azure_skills.py	Updated as part of this pull request.
src/azure-cli/azure/cli/command_modules/acs/custom.py	Updated as part of this pull request.
src/azure-cli/azure/cli/command_modules/acs/_params.py	Updated as part of this pull request.
src/azure-cli/azure/cli/command_modules/acs/_help.py	Updated as part of this pull request.
src/azure-cli/azure/cli/command_modules/acs/_azure_skills.py	Updated as part of this pull request.
docs/superpowers/specs/2026-09-18-aks-azure-skills-design.md	Updated as part of this pull request.
docs/superpowers/plans/2026-09-18-aks-azure-skills.md	Updated as part of this pull request.
docs/superpowers/implementation/2026-09-19-aks-azure-skills.md	Updated as part of this pull request.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Aditya Pujara (a0x1ab) · 2026-09-19T02:15:41Z

/azp run

azure-pipelines · 2026-09-19T02:15:58Z

Azure Pipelines: Successfully started running 3 pipeline(s).

Aditya Pujara (a0x1ab) · 2026-09-19T02:40:28Z

/azp run

azure-pipelines · 2026-09-19T02:40:45Z

Azure Pipelines: Successfully started running 3 pipeline(s).

FumingZhang

I found three issues to address before merge: an unhandled home-directory resolution failure, a parser test that is already failing in both full-test jobs, and the blocking style violations.

FumingZhang

please consider adding a scenario test case to help validate the change

Aditya Pujara (a0x1ab) · 2026-09-21T21:37:36Z

/azp run

azure-pipelines · 2026-09-21T21:37:54Z

Azure Pipelines: Successfully started running 3 pipeline(s).

FumingZhang · 2026-09-22T00:29:00Z

+def discover_agents() -> list[AgentTarget]:
+    try:
+        home = Path.home()
+    except RuntimeError as error:


[P2] Path.home() can raise RuntimeError when the home directory cannot be resolved, such as in a minimal container running under a numeric UID with no HOME or passwd entry. Before this catch was added, that failure escaped as a raw traceback after binary installation. Handling it as FileOperationError preserves optional-mode binary success and gives explicit mode a normal CLI error.

FumingZhang · 2026-09-22T00:29:00Z

+    def test_invalid_agent_is_rejected_by_parser(self):
+        result, handler = self.invoke(['--install-azure-skills', '--skills-agents', 'unknown'])
+        self.assertEqual(result, 2)
+        handler.assert_not_called()


[P1] The previous assertion against a late sys.stderr patch failed deterministically in both Python 3.12 and 3.14 full-test jobs because the CLI logging handlers were not guaranteed to write there. Keeping this test focused on exit code 2 and confirming that the command handler was not called removes the merge-blocking false failure.

FumingZhang · 2026-09-22T00:29:00Z

+                reasons.append(failure)
+            failure = 'Azure skills installation is incomplete. ' + '; '.join(reasons)
+    if failure:
+        message = (f'{failure} kubectl and kubelogin remain installed. {source} ' +


[P1] This expression previously triggered the required style gate (W503), alongside several pylint violations in the new module, and therefore blocked the PR from merging. The refactoring now satisfies the style checks; the priority reflects the merge-blocking gate rather than a runtime defect.

Tom Gamble (gambtho) added 17 commits September 18, 2026 15:22

docs: design optional AKS Azure skills installation

5e6c1ec

docs: clarify Azure skills recovery and authentication

b57a351

docs: plan native AKS Azure skills installation

83dfbd2

feat(aks): add Azure skills agent selection and preflight

d833deb

feat(aks): retrieve Azure skills with bounded authenticated metadata

793fd59

fix(aks): enforce Azure skills deadlines at socket reads

d0b6770

feat(aks): safely stage Azure skill bundles and resources

13d77db

fix(aks): reject short Azure skills archive members

04cb904

feat(aks): publish Azure skills without overwriting existing content

900c378

fix(aks): preserve lexical skill paths until safety validation

b88eb7f

feat(aks): offer native Azure skills installation from install-cli

8d57b18

fix(aks): preserve nested Azure skill supporting guides

c710087

fix(aks): keep Azure skills consent visible in quiet mode

25c78cd

docs: record Azure skills implementation and verification

b12fd01

style(aks): align Azure skills continuation indentation

ba2df92

fix(aks): conform Azure skills errors and prompts to CLI guidelines

120e0e3

chore(aks): finish CodeRabbit review follow-up

560bdc9

Copilot AI lite review requested due to automatic review settings September 19, 2026 02:06

Tom Gamble (gambtho) requested review from a team and FumingZhang as code owners September 19, 2026 02:06

azure-client-tools-bot-prd Bot added this to the October 2026 (2026-10-06) milestone Sep 19, 2026

microsoft-github-policy-service Bot requested review from elvazhu521, Yu Chen (jsntcy), ZelinWang (wangzelin007), Julie Zhu (yanzhudd) and Yong Zhang (yonzhan) September 19, 2026 02:06

Copilot started reviewing on behalf of Tom Gamble (gambtho) September 19, 2026 02:07 View session

Copilot AI reviewed Sep 19, 2026

View reviewed changes

chore: remove internal planning docs from PR

cf3674d

Yong Zhang (yonzhan) assigned Julie Zhu (yanzhudd) Sep 19, 2026

Yong Zhang (yonzhan) requested a review from Ethan Yang (necusjz) September 19, 2026 11:44

FumingZhang reviewed Sep 21, 2026

View reviewed changes

Comment thread src/azure-cli/azure/cli/command_modules/acs/_azure_skills.py Outdated

Comment thread src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_azure_skills.py Outdated

Comment thread src/azure-cli/azure/cli/command_modules/acs/_azure_skills.py Outdated

FumingZhang reviewed Sep 21, 2026

View reviewed changes

Tom Gamble (gambtho) added 7 commits September 21, 2026 11:05

fix(acs): handle unresolved skills home and stabilize parser test

a1eaea7

fix(acs): resolve Azure skills helper style violations

52fc48f

test(acs): cover Azure skills install-cli scenario

bcd316e

test(acs): isolate cached cloud config in skills scenario

f74bb41

test(acs): suppress inherited cloud metadata in skills scenario

5a35cac

test(acs): isolate scenario cloud and extension caches

3553fd6

test(acs): keep skills scenario CLI startup offline

a50c500

FumingZhang reviewed Sep 22, 2026

View reviewed changes

Tom Gamble (gambtho) mentioned this pull request Sep 22, 2026

[AKS] az aks install-cli: Add optional host-managed Azure plugin setup #34115

Open

3 tasks

rule	cmd_name	rule_message	suggest_message
⚠️ 1006 - ParaAdd	aks install-cli	cmd `aks install-cli` added parameter `install_azure_skills`
⚠️ 1006 - ParaAdd	aks install-cli	cmd `aks install-cli` added parameter `skills_agents`

Conversation

Tom Gamble (gambtho) commented Sep 19, 2026 • edited by x-engineering-agent Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 PR Validation — ⚠️ Review suggested

Uh oh!

azure-pipelines Bot commented Sep 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Aditya Pujara (a0x1ab) commented Sep 19, 2026

Uh oh!

azure-pipelines Bot commented Sep 19, 2026

Uh oh!

Aditya Pujara (a0x1ab) commented Sep 19, 2026

Uh oh!

azure-pipelines Bot commented Sep 19, 2026

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

Aditya Pujara (a0x1ab) commented Sep 21, 2026

Uh oh!

azure-pipelines Bot commented Sep 21, 2026

Uh oh!

FumingZhang Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FumingZhang Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FumingZhang Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Tom Gamble (gambtho) commented Sep 19, 2026 •

edited by x-engineering-agent Bot

Loading

FumingZhang Sep 22, 2026 •

edited

Loading

FumingZhang Sep 22, 2026 •

edited

Loading

FumingZhang Sep 22, 2026 •

edited

Loading