Skip to content

Import _get_location_from_webapp from azure.cli.command_modules.appservice.utils#9888

Merged
yanzhudd merged 4 commits into
Azure:mainfrom
patelchandni:updateimport
May 21, 2026
Merged

Import _get_location_from_webapp from azure.cli.command_modules.appservice.utils#9888
yanzhudd merged 4 commits into
Azure:mainfrom
patelchandni:updateimport

Conversation

@patelchandni
Copy link
Copy Markdown
Contributor

@patelchandni patelchandni commented May 19, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Import _get_location_from_webapp from azure.cli.command_modules.appservice.utils

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings May 19, 2026 21:05
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented May 19, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented May 19, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the appservice-kube extension to accommodate a refactor in Azure CLI App Service internals by switching the import source for _get_location_from_webapp, and publishes a new extension version.

Changes:

  • Bump extension version to 0.1.12
  • Import _get_location_from_webapp from azure.cli.command_modules.appservice.utils instead of ...appservice.custom
  • Add release notes entry for 0.1.12

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/appservice-kube/setup.py Bumps the extension package version for the release.
src/appservice-kube/azext_appservice_kube/custom.py Updates import location of _get_location_from_webapp to match upstream CLI changes.
src/appservice-kube/HISTORY.rst Adds a 0.1.12 changelog entry describing the import change.

Comment thread src/appservice-kube/azext_appservice_kube/custom.py Outdated
Comment thread src/appservice-kube/azext_appservice_kube/custom.py Outdated
Comment thread src/appservice-kube/HISTORY.rst Outdated
@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

@github-actions github-actions Bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 19, 2026
@yonzhan yonzhan assigned yanzhudd and unassigned zhoxing-ms May 19, 2026
@patelchandni
Copy link
Copy Markdown
Contributor Author

this is pre-req for PR: Azure/azure-cli#33341

@github-actions github-actions Bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 19, 2026
@yanzhudd
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

yanzhudd
yanzhudd previously approved these changes May 20, 2026
@patelchandni
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 9888 in repo Azure/azure-cli-extensions

@yanzhudd
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd yanzhudd merged commit fc454ad into Azure:main May 21, 2026
24 checks passed
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ appservice-kube-1.0.0b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=165025183&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants