Import _get_location_from_webapp from azure.cli.command_modules.appservice.utils#9888
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the appservice-kube extension to accommodate a refactor in Azure CLI App Service internals by switching the import source for _get_location_from_webapp, and publishes a new extension version.
Changes:
- Bump extension version to
0.1.12 - Import
_get_location_from_webappfromazure.cli.command_modules.appservice.utilsinstead of...appservice.custom - Add release notes entry for
0.1.12
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/appservice-kube/setup.py | Bumps the extension package version for the release. |
| src/appservice-kube/azext_appservice_kube/custom.py | Updates import location of _get_location_from_webapp to match upstream CLI changes. |
| src/appservice-kube/HISTORY.rst | Adds a 0.1.12 changelog entry describing the import change. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
|
this is pre-req for PR: Azure/azure-cli#33341 |
61fdcc4 to
fb5c52c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
fb5c52c to
dd1937a
Compare
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9888 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ appservice-kube-1.0.0b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=165025183&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Import _get_location_from_webapp from azure.cli.command_modules.appservice.utils
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.