Fix winrm listeners data type

[coolhome]

Description

winRM is passed to listeners, which is an array and not an object. I was not able to perform set-module on the virtual machine construct, that template is broken.

Pipeline references

Pipeline

Type of Change

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Update to documentation

Checklist

• I'm sure there are no other open Pull Requests for the same update/change
• My corresponding pipelines / checks run clean and green without any errors or warnings
• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (readme)
• I did format my code

[AlexanderSehr]

Hey @coolhome,
the construct template definitely is. It's essentially just code we parked when initially migrating all modules from ARM to Bicep. In the future setup with AVM, it would be considered a pattern.
I think the reason we did not outright delete it was that it contains logic to generate x amount of VM names for the deploying person.

[coolhome]

I do want to mention that this looks like it meant to be a type WinRMConfiguration but in actuality its WinRMListener. Maybe the solution is to remove the listener mapping and allow users to pass the WinRMConfiguration type?

[AlexanderSehr]

@rahalan, note this update may be relevant for the AVM VM PR. However, @coolhome could it be the encoding or something similar was changed? The files appears completely new which makes it very hard to sport what actually changed.

[coolhome]

@AlexanderSehr yah I just noticed that as well. I have core.autocrlf=false and I think this is the root cause.

This is not really a solution but a way to see the differences without the newline issue.

Let me know if you want to re-create the PR. I am also happy with whatever.

[coolhome]

Closing since its now implemented in Azure/bicep-registry-modules#717 for AVM.

[AlexanderSehr]

Hey @coolhome, may I ask you to re-open the PR? I think for VMSS this is still very much relevant, isn't it? This module isn't migrated yet / started.

[TheMarcosP]

h

[AlexanderSehr]

Hey @rahlan, I take it it's save to say you don't have this on your radar these days.
Could you please check if the contribution is already implemented in the VM/VMSS module and if not ideally consider to add it?