Skip to content

fix(vscode): Node 24 / VS Code 1.123 compatibility and fallback handling for connector prompts#9257

Open
lambrianmsft wants to merge 1 commit into
Azure:hotfix/v5.961from
lambrianmsft:hotfix/v5.961-vscode-extension-issue
Open

fix(vscode): Node 24 / VS Code 1.123 compatibility and fallback handling for connector prompts#9257
lambrianmsft wants to merge 1 commit into
Azure:hotfix/v5.961from
lambrianmsft:hotfix/v5.961-vscode-extension-issue

Conversation

@lambrianmsft
Copy link
Copy Markdown
Contributor

@lambrianmsft lambrianmsft commented Jun 6, 2026

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Users have to revert to a previous version of vscode in order to use the vscode extension otherwise they are running into issues with creating a workspace and debugging logic apps.

Impact of Change

  • Users:
    Users should now be able to use the latest version of vscode with our extension.
  • Developers:
  • System:

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

Screenshots/Videos

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2026 •
edited
Loading

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

  • Current: fix(vscode): Node 24 / VS Code 1.123 compatibility and fallback handling for connector prompts
  • Issue: None blocking. The title is specific, scoped, and clearly describes the compatibility/fallback behavior.
  • Recommendation: No change needed.

✅ Commit Type

  • Properly selected (fix).
  • Only one commit type is selected, which is correct.

⚠️ Risk Level

  • The submitted risk label is risk:medium, and the PR body also selects Medium. That matches.
  • Advised risk level: medium.
  • Based on the diff, this remains a moderate-risk change because it touches runtime dependency installation, language-server startup, and connector prompt fallback behavior.

✅ What & Why

  • Current: Users have to revert to a previous version of vscode in order to use the vscode extension otherwise they are running into issues with creating a workspace and debugging logic apps.
  • Issue: Slightly broad, but sufficient.
  • Recommendation: Consider making the root cause and outcome more explicit, e.g. Fix compatibility with Node 24 / VS Code 1.123 so users can create workspaces and debug Logic Apps without downgrading VS Code.

⚠️ Impact of Change

  • The section is mostly filled, but it is sparse for Developers and System.
  • Recommendation:
    • Users: Keep as-is or mention that connector prompts now default safely when cancelled.
    • Developers: Add a short note like Updates wizard fallback handling and runtime dependency path resolution; language server and installer flows now use the ensured dependency path.
    • System: Add a note like Touches startup/install flows and adds compatibility shims for newer Node runtimes.

✅ Test Plan

  • Passes.
  • The diff includes both unit tests and E2E tests, so the test-plan checkbox selection is backed by actual test code.
  • No issue here.

✅ Contributors

  • Blank, but that is allowed.
  • No action required.

✅ Screenshots/Videos

  • Blank, which is acceptable because this is not primarily a visual/UI-only change.

Summary Table

Section Status Recommendation
Title ✅
Commit Type ✅
Risk Level ✅
What & Why ⚠️ Make the compatibility fix/outcome more explicit
Impact of Change ⚠️ Add concise Developer and System impact notes
Test Plan ✅
Contributors ✅
Screenshots/Videos ✅

PR body passes overall, but it would be stronger with a more explicit What & Why and fuller Impact of Change section. The advised risk level is medium, matching the submitter's assessment.

Last updated: Sat, 06 Jun 2026 04:54:30 GMT

@lambrianmsft
fix(vscode): Node 24 / VS Code 1.123 compatibility and fallback handl…
2c6761d 
…ing for connector prompts (Azure#9246)

* fix(vscode): support Node 24 activation

Restore legacy node:util helpers required by Azure extension utilities under VS Code's Node 24 runtime and harden Logic Apps language server startup when project or dependency paths are missing.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* test(vscode): add Node compatibility E2E lane

Allow run-e2e.js to target an explicit VS Code version while keeping the default suite pinned. Add compatibility activation smokes for Node 20/22 with VS Code 1.108 and Node 24 with VS Code 1.123 so the latest extension is checked against both older and newer VS Code/Electron runtimes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(vscode): ensure runtime dependency root

Default and create the Logic Apps runtime dependencies path at dependency-install boundaries before installing LSP, Node, .NET, or Functions Core Tools assets. Also make dependency downloads wait for stream completion and fail on writer/readable stream errors.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(vscode): suppress repeated health check logs

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* test(vscode): cover unhealthy health check logs

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(vscode): default cancelled connector prompts to keys

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* test(vscode): preflight VS Code CLI path

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(vscode): stabilize debug startup checks

Narrow language server startup to linked custom code projects, avoid connector metadata warm-up during design-time startup, and make p43 E2E failures report runtime readiness before overview navigation. Add focused coverage for runtime dependency installers and Azure connector wizard fallbacks, with narrow coverage exclusions for VS Code orchestration and shared install plumbing.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* test(vscode): stabilize custom code dependency wait

Use the shared dependency validation helper in designer actions and re-resolve the Functions Core Tools binary path while polling so CI handles layouts where func moves under in-proc folders after validation reinstalls dependencies.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* test(vscode): find nested func runtime binaries

Discover the Functions Core Tools executable recursively under the dependency cache and give the designer actions before hook enough time to report dependency diagnostics instead of being killed by Mocha.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(vscode): address dependency cleanup review

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(vscode): reinstall incomplete runtime dependencies

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@lambrianmsft lambrianmsft force-pushed the hotfix/v5.961-vscode-extension-issue branch from a83ce89 to 2c6761d Compare June 6, 2026 04:21
@lambrianmsft lambrianmsft added the risk:medium Medium risk change with potential impact label Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eric-B-Wu Eric-B-Wu Eric-B-Wu approved these changes

Assignees

No one assigned

Labels

pr-validated risk:medium Medium risk change with potential impact

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lambrianmsft @Eric-B-Wu