Show operation default setting values and host settings in the designer#9253
Open
JoaquimMalcampo wants to merge 5 commits into
Open
Show operation default setting values and host settings in the designer#9253JoaquimMalcampo wants to merge 5 commits into
JoaquimMalcampo wants to merge 5 commits into
Conversation
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | |
| Commit Type | ✅ | |
| Risk Level | Consider high if you want the label/body to reflect the new serialization and fetch behavior more conservatively. |
|
| What & Why | ✅ | |
| Impact of Change | Add explicit note that host settings are read-only and that initialization now makes an extra cached backend call. | |
| Test Plan | ✅ | |
| Contributors | Add names if anyone else contributed. | |
| Screenshots/Videos | ✅ |
Overall: the PR body passes, but I recommend revisiting the risk label/body to ensure it matches the scope of the change.
Last updated: Fri, 05 Jun 2026 17:46:38 GMT
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the Designer settings panel to display concrete default operation setting values returned by the backend settingDefaults API (instead of an opaque “Default”), and surfaces unknown host-level settings in a new read-only “Host settings” section—while keeping workflow JSON serialization behavior unchanged.
Changes:
- Add a React Query–cached
settingDefaultsfetch + merge path during operation initialization/deserialization. - Extend settings types (
SettingData,Settings,SettingSectionName) to support read-only/default-hint semantics and host-level settings display. - Add a new Settings panel section to render host-level settings as read-only text fields.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Localize/lang/strings.json | Adds localization entry for the new “Host settings” section title. |
| libs/logic-apps-shared/src/designer-client-services/lib/operationmanifest.ts | Extends the operation manifest service interface with optional getSettingDefaults. |
| libs/logic-apps-shared/src/designer-client-services/lib/standard/operationmanifest.ts | Implements getSettingDefaults for Standard (including hybrid proxy path). |
| libs/logic-apps-shared/src/designer-client-services/lib/consumption/operationmanifest.ts | Implements getSettingDefaults for Consumption using the existing baseUrl/connectorId URL pattern. |
| libs/designer/src/lib/ui/settings/sections/hostsettings.tsx | New UI section that renders host-level settings as read-only fields. |
| libs/designer/src/lib/ui/settings/index.tsx | Wires the new Host Settings section into the Settings panel and centralizes SettingSectionName. |
| libs/designer/src/lib/core/state/setting/settingInterface.ts | Adds HOSTSETTINGS to the settings section name map. |
| libs/designer/src/lib/core/queries/settingDefaults.ts | Adds supported-settings key extraction, React Query fetch, and merge logic (including hostSettings routing). |
| libs/designer/src/lib/core/actions/bjsworkflow/settings.ts | Extends settings types to support readOnly, defaultHint, and hostSettings. |
| libs/designer/src/lib/core/actions/bjsworkflow/serializer.ts | Avoids serializing retry policy when it was populated from API defaults (via defaultHint). |
| libs/designer/src/lib/core/actions/bjsworkflow/operationdeserializer.ts | Fetches and merges setting defaults during manifest-based operation initialization. |
| libs/designer/src/lib/core/actions/bjsworkflow/add.ts | Fetches and merges setting defaults during operation creation/initialization flows. |
| libs/designer-v2/src/lib/core/actions/bjsworkflow/settings.ts | Adds readOnly to v2 SettingData to keep parity for read-only settings support. |
|
|
||
| const title = intl.formatMessage({ | ||
| defaultMessage: 'Host settings', | ||
| id: 'xhrvz3', |
Comment on lines
+63
to
+67
| try { | ||
| return await getReactQueryClient().fetchQuery( | ||
| ['settingDefaults', connectorId.toLowerCase(), operationId.toLowerCase(), workflowKind ?? ''], | ||
| () => service.getSettingDefaults!(connectorId, operationId, supportedSettings, workflowKind) | ||
| ); |
Comment on lines
+1
to
+2
| import type { HeaderClickHandler } from '..'; | ||
| import { SettingSectionName } from '..'; |
Contributor
📊 Coverage CheckThe following changed files need attention:
Please add tests for the uncovered files before merging. |
JoaquimMalcampo
changed the title
github-actions
Bot
added
pr-validated
needs-pr-update
and removed
needs-pr-update
pr-validated
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
Adds UI visibility for operation setting defaults returned by the settingDefaults API. Previously, settings like retry policy showed "Default" with no detail fields when no explicit value was set in the workflow definition. Now the designer fetches defaults from the host and displays actual values (e.g., "Exponential interval", count, intervals) while preserving the existing serialization behavior — no changes are written to the workflow JSON.
Additionally, unknown host-level settings returned by the API (e.g., maxMessageBatchSize) are now surfaced in a new read-only "Host settings" section in the settings panel.
Changes
Impact of Change
Settings panel now shows actual default values for retry policy and other settings instead of an opaque "Default" label. Host-level read-only settings (e.g., maxMessageBatchSize) are visible in a new collapsible section. No changes to saved workflow definitions.
New defaultHint field on SettingData — indicates the value came from API defaults and should not be serialized. hostSettings on Settings is a dynamic Record<string, SettingData> for arbitrary host-returned keys. KNOWN_SETTING_KEYS set in settingDefaults.ts controls which API keys are treated as known vs host-level.
One additional HTTP call per operation during deserialization (cached by React Query). No changes to workflow JSON serialization output.
Test Plan
Contributors
Screenshots/Videos