Updates to allow for log folders to be directly in the root of a bucket - #14995
Open
gallen-ms wants to merge 5 commits into
Open
Updates to allow for log folders to be directly in the root of a bucket#14995gallen-ms wants to merge 5 commits into
gallen-ms wants to merge 5 commits into
Conversation
Updated version numbers for solution and data connector. Updated connector to accept an empty s3BucketPrefix value and when provided the user should supply a trailing slash
Updated the release notes to include version 3.3.2 changes.
v-atulyadav
added
Solution
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Cisco Umbrella solution to support Amazon S3 log folders located directly at the bucket root by making the S3 bucket prefix optional and adjusting prefix/path handling and guidance.
Changes:
- Bumped solution/connector versions to 3.3.2 and added release notes entry.
- Made
s3BucketPrefixoptional in the connector UI/template and updated instructional markdown. - Adjusted polling config path concatenation to avoid injecting a leading slash when prefix is empty.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Solutions/CiscoUmbrella/ReleaseNotes.md | Adds 3.3.2 release note describing optional prefix + trailing slash guidance. |
| Solutions/CiscoUmbrella/Package/mainTemplate.json | Makes prefix optional, updates UI/help text, and updates prefix concatenation logic. |
| Solutions/CiscoUmbrella/Data/Solution_CiscoUmbrella.json | Bumps solution version to 3.3.2. |
| Solutions/CiscoUmbrella/Data Connectors/CiscoUmbrella_CCP/CiscoUmbrella_PollingConfig.json | Updates prefix concatenation for each log type path. |
| Solutions/CiscoUmbrella/Data Connectors/CiscoUmbrella_CCP/CiscoUmbrella_DataConnectorDefinition.json | Makes prefix optional and adds guidance note + example update. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "s3BucketName": "[[parameters('s3BucketName')]", | ||
| "s3BucketRegion": "[[parameters('s3BucketRegion')]", | ||
| "s3BucketPrefix": "[[concat(parameters('s3BucketPrefix'),'/auditlogs/')]", | ||
| "s3BucketPrefix": "[[concat(parameters('s3BucketPrefix'),'auditlogs/')]", |
| @@ -5875,8 +5887,8 @@ | |||
| }, | |||
| "s3BucketPrefix": { | |||
| "defaultValue": "s3BucketPrefix", | |||
| { | ||
| "type": "Markdown", | ||
| "parameters": { | ||
| "content": "> **NOTE:**\n> For Customer managed paths, you can leave the S3 Bucket Prefix empty if you want to use the root of the bucket. If you specify a prefix, make sure to include the trailing slash." |
| { | ||
| "type": "Markdown", | ||
| "parameters": { | ||
| "content": "> **NOTE:**\n> For Customer managed paths, you can leave the S3 Bucket Prefix empty if you want to use the root of the bucket. If you specify a prefix, make sure to include the trailing slash." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: