Silent Push connector initial version - #14961
Conversation
@microsoft-github-policy-service agree |
1 similar comment
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Initial introduction of the Silent Push Microsoft Sentinel solution, including solution metadata, packaging assets, and multiple Logic App playbook ARM templates for enrichment and (in “Full” variants) Threat Intelligence upload.
Changes:
- Added solution metadata + release notes for Silent Push
- Added CreateUI + test parameters for solution packaging
- Added 4 Logic App playbook ARM templates (2 enrichment-only, 2 enrichment + TI upload + RBAC)
Reviewed changes
Copilot reviewed 9 out of 13 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| Solutions/SilentPush/SolutionMetadata.json | Adds Solution offer/publisher metadata and support details |
| Solutions/SilentPush/ReleaseNotes.md | Adds initial release notes entry/table |
| Solutions/SilentPush/Playbooks/SilentPush-IPExportEnrichment/azuredeploy.json | Adds ARM template for IP export + enrichment playbook |
| Solutions/SilentPush/Playbooks/SilentPush-IPExportEnrichment-Full/azuredeploy.json | Adds ARM template for IP export + enrichment + TI upload + RBAC |
| Solutions/SilentPush/Playbooks/SilentPush-DomainExportEnrichment/azuredeploy.json | Adds ARM template for domain export + enrichment playbook |
| Solutions/SilentPush/Playbooks/SilentPush-DomainExportEnrichment-Full/azuredeploy.json | Adds ARM template for domain export + enrichment + TI upload + RBAC |
| Solutions/SilentPush/Package/testParameters.json | Adds test parameters used for ARM-TTK / packaging |
| Solutions/SilentPush/Package/createUiDefinition.json | Adds Marketplace UI definition for workspace selection + outputs |
| Solutions/SilentPush/Data/Solution_SilentPush.json | Adds solution manifest (assets list, version, metadata pointer) |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 13 changed files in this pull request and generated 3 comments.
Suppressed comments (1)
Solutions/SilentPush/Package/createUiDefinition.json:90
- Filtering workspaces by
contains(..., resourceGroup().name)is brittle because it can match unintended substrings and doesn’t explicitly ensure the workspace is in the selected resource group. A more robust approach is to check for'/resourceGroups/{rgName}/'in the resourceId or compare parsed segments. Also, the tooltip text should be grammatically correct (“workspaces” instead of “workspace”) to avoid confusing users.
|
Hi Jorgeley (@Jorgeley-SilentPush), Additionally, remove the section mentioned below from the playbook. Please verify all playbooks for the same issue and apply the fix wherever applicable. "location": { Once all changes are completed, repackage the solution and upload the updated package. Please refer below image for reference where it used as "location": "[resourceGroup().location]".
|
done |
|
Hi Jorgeley (@Jorgeley-SilentPush) , |
|
Hi Jorgeley (@Jorgeley-SilentPush) , |
|
v-rusraut, done |
|
Hi Jorgeley (@Jorgeley-SilentPush) , Please resolved below arm ttk error
|
v-rusraut please read my comments, this arm ttk error is the opposite of the last one, so we're in a fix-refix endless loop |
|
Hi Jorgeley (@Jorgeley-SilentPush) , I think you have updated mainTemplate manually. Once the suggested playbook changes are completed, the solution should be repackaged using the V3 packaging tool, which will prevent this validation error. Please create package of solution using v3 tool - Azure-Sentinel/Tools/Create-Azure-Sentinel-Solution/V3/README.md at master · Azure/Azure-Sentinel and commit the changes. And please share the screen shots of Playbook workflow running successfully. |
hi v-rusraut , your assumption is wrong, I didn't manually change mainTemplate.json, I'm using the V3 packaging tool, specifically this command: Also, the last 2 PR review comments were conflicting each other (asking to do the opposite of each other), can you clarify which of the below changes I need to have in all playbooks?
In addition, I already included screenshots in previous PR review comments, do I need to do it everytime? |
|
Hi Jorgeley (@Jorgeley-SilentPush) , |







Change(s):
Reason for Change(s):
Testing Completed: