feat: only verify new headers - #25404
Open
alexghr wants to merge 1 commit into
Open
Conversation
alexghr
commented
Sep 4, 2026
| ); | ||
|
|
||
| for (uint256 i = 0; i < numCheckpoints; i++) { | ||
| for (uint256 i = _firstHeaderToVerify; i < numCheckpoints; i++) { |
Contributor
Author
There was a problem hiding this comment.
this is the whole patch.
spalladino
approved these changes
Sep 4, 2026
spalladino
left a comment
spalladino
left a comment
Contributor
There was a problem hiding this comment.
Looks good, left one question.
Also, how much could we save by not sending the headers? Calldata gas is cheap but not that cheap. If that header prefix is ignored, maybe we don't even need to send it at all?
Comment on lines
+120
to
+121
| uint256 provenPrefixLength = provenBeforeSubmission - _args.start + 1; | ||
| uint256 accountedPrefixLength = RewardLib.getLongestProvenLength(endEpoch); |
Contributor
There was a problem hiding this comment.
When would these two differ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the checkpoint header verification from always verifying from index 0 (in the epoch) up to the current proven tip to verifying from the last proven index to up the new proven tip. This reduces the gas cost for partial epoch proofs by about ~3-4k per previously verified checkpoint header.
Fix A-1802