Skip to content

fix: type-safe config parseEnv return types #22530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalladino merged 1 commit into from
Apr 14, 2026
Merged

fix: type-safe config parseEnv return types #22530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion yarn-project/p2p/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ export const p2pConfigMappings: ConfigMappingsType<P2PConfig> = {
l1PublishingTime: {
env: 'SEQ_L1_PUBLISHING_TIME_ALLOWANCE_IN_SLOT',
description: 'How much time (in seconds) we allow in the slot for publishing the L1 tx (defaults to 1 L1 slot).',
parseEnv: (val: string) => (val ? parseInt(val, 10) : undefined),
parseEnv: (val: string) => parseInt(val, 10),
},
fishermanMode: {
env: 'FISHERMAN_MODE',
Expand Down
2 changes: 1 addition & 1 deletion yarn-project/stdlib/src/config/sequencer-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const sharedSequencerConfigMappings: ConfigMappingsType<
attestationPropagationTime: {
env: 'SEQ_ATTESTATION_PROPAGATION_TIME',
description: 'How many seconds it takes for proposals and attestations to travel across the p2p layer (one-way).',
parseEnv: (val: string) => (val ? parseFloat(val) : undefined),
parseEnv: (val: string) => parseFloat(val),
defaultValue: DEFAULT_P2P_PROPAGATION_TIME,
},
};
Loading