fix: skip heavy recursion tests in nightly debug builds#22488
Draft
fix: skip heavy recursion tests in nightly debug builds#22488
Conversation
AvmRecursionInnerCircuitTests, HonkRecursionConstraintTest, and ChonkRecursionConstraintTest take 400-600s each in debug mode, causing nightly timeouts. Skip them but keep one test (GenerateVKFromConstraints) to cover the debug-only native_verification_debug code path.
AztecBot
added
ci-draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes nightly barretenberg debug build failure that has been failing consecutively since April 7.
Root cause:
AvmRecursionInnerCircuitTests.Tampering(and other heavy recursion tests) fromvm2_teststime out at 600s in debug builds. These tests take 400-600s each in unoptimized debug mode.Fix: Skip
HonkRecursionConstraintTest,ChonkRecursionConstraintTest, andAvmRecursionInnerCircuitTestssuites in debug builds. KeepHonkRecursionConstraintTestWithoutPredicate/1.GenerateVKFromConstraints(241s) so the debug-onlynative_verification_debugcode path inhonk_recursion_constraint.cppis still exercised.Note: This same fix was merged via PR #22389 into
merge-train/barretenbergon April 10, but the merge-train PR #22447 has not yet landed onnext, so the nightly keeps failing. This PR applies the fix directly tonextto unblock the nightly build immediately.Test plan
GenerateVKFromConstraintstestClaudeBox log: https://claudebox.work/s/189fbaf3fe1adf3c?run=1