chore: backport #22393 (Update Noir to nightly-2026-04-10) to v4-next#22485
Open
AztecBot wants to merge 14 commits intobackport-to-v4-next-stagingfrom
Open
chore: backport #22393 (Update Noir to nightly-2026-04-10) to v4-next#22485AztecBot wants to merge 14 commits intobackport-to-v4-next-stagingfrom
AztecBot wants to merge 14 commits intobackport-to-v4-next-stagingfrom
Conversation
Cherry-pick of merge commit 0daa54d with conflicts. Conflicts in: avm-transpiler/Cargo.lock, noir-projects Nargo.toml files, noir-projects macro files, noir/noir-repo submodule.
Resolved conflicts by taking the PR side for all changes: - poseidon v0.2.3 -> v0.3.0 in Nargo.toml files - bignum v0.9.0 -> v0.10.0, bigcurve v0.13.0 -> v0.14.0 in blob/rollup-lib - indexmap 2.13.0 -> 2.13.1, added itertools in Cargo.lock - Comment reformatting to 120-char line limit in .nr files - Updated noir/noir-repo submodule to 842974fcf034b0
AztecBot
added
ci-draft
Cherry-pick of 17ba18a — removes unnecessary 'let mut' across noir-projects (now errors in newer Noir). Conflicts in private_context.nr and discovery/mod.nr resolved by keeping HEAD which already has the fixes via newer code. Cargo.lock/yarn.lock/submodule kept at our versions.
…ds from macros) Cherry-pick of 5de59a7 — replaces deprecated Noir comptime APIs: - add_attribute('abi(events)') -> add_abi('events') - set_body/set_parameters/add_attribute/set_return_public -> function.disable() - fn_has_noinitcheck now also checks is_fn_only_self() - Removes f.add_attribute('noinitcheck') from only_self
- Remove unnecessary mut from is_static_call in private_context.nr - Simplify fn_has_noinitcheck in utils.nr to match next
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
benesjan
added
ci-no-fail-fast
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
benesjan
requested review from
a team,
IlyasRidhuan,
LeilaWang,
Maddiaa0,
fcarreiro,
jeanmon and
nventuro
as code owners
benesjan
reviewed
Apr 12, 2026
| function_locations: z.array(z.object({ start: z.number(), name: z.string() })), | ||
| }), | ||
| ), | ||
| ) as z.ZodType<DebugFileMap>, |
Contributor
There was a problem hiding this comment.
This is the only fuckery needed to be able to successfully finish the backport.
The change in Noir was introduced in this PR
benesjan
approved these changes
Apr 12, 2026
Contributor
benesjan
left a comment
benesjan
left a comment
There was a problem hiding this comment.
Other than the changes to abi.ts the backport was "fully" clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #22393 (Update Noir to nightly-2026-04-10) to v4-next, plus 3 companion PRs needed for Noir compatibility since v4-next was still on nightly-2026-02-12.
Companion PRs included
Since v4-next hadn't updated Noir since nightly-2026-02-12 (~2 months behind), several intermediate Noir-adaptation PRs were also needed:
comptimequalifier from VK tree constants (Noir broke comptime globals used in non-comptime contexts)let mutacross noir-projects (newer Noir errors on this)add_attribute()→add_abi(),set_body()/set_parameters()/set_return_public()→function.disable(), updatefn_has_noinitcheckto also checkis_fn_only_self()Commits