fix: check all aztec-nr dependency tags, not just aztec#22483
Open
benesjan wants to merge 1 commit intomerge-train/fairiesfrom
Open
fix: check all aztec-nr dependency tags, not just aztec#22483benesjan wants to merge 1 commit intomerge-train/fairiesfrom
benesjan wants to merge 1 commit intomerge-train/fairiesfrom
Conversation
Broaden `warnIfAztecVersionMismatch` to flag any dependency sourced from the AztecProtocol/aztec-nr repo whose tag does not match the CLI version, instead of only checking the dep literally named `aztec`. The warning now names the offending dep so users know exactly which one to bump. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now we have only checked that
aztecdep matches the version ofaztec cli. This was incomplete as there are also other crates in the aztec-nr repo (e.g.uint_note) that should have this same check applied to them. In this PR I tackle that.AI Summary
warnIfAztecVersionMismatchto inspect every dependency in a contract'sNargo.tomlwhose git URL points atgithub.com/AztecProtocol/aztec-nr, rather than only the single dep literally namedaztec.uint_note,compressed_string,balance_set, etc. are now flagged when theirtagdrifts from the CLI version (common afteraztec-upforgets one)..gitsuffixes and trailing slashes.Closes F-504.
🤖 Generated with Claude Code