feat: Goblin flush with Mega arithmetisation#22465
Open
federicobarbacovi wants to merge 47 commits intomerge-train/barretenbergfrom
Open
feat: Goblin flush with Mega arithmetisation#22465federicobarbacovi wants to merge 47 commits intomerge-train/barretenbergfrom
federicobarbacovi wants to merge 47 commits intomerge-train/barretenbergfrom
Conversation
- transcript_builder: gate hiding op handling on is_zk so index 0 goes through the normal main loop when is_zk=false (root bug: sentinel x-coordinate was written to ECCVM Px without infinity flag, causing ECCVM/Translator accumulated_result mismatch) - ecc_op_queue: add get_is_zk() getter; remove (0,0) coordinate override in eq_and_reset that destroyed the infinity flag (the transcript builder already zeros coords for infinity points) - eccvm_flavor: pass is_zk to compute_rows - goblin.hpp: add set_op_queue_zk() setter - mock_circuits: restructure for non-ZK — only last-prepended circuit gets 4 leading no-ops (translator padding), every circuit gets eq_and_reset, end random ops gated on is_zk - goblin_verifier.test: set op_queue_zk(false), add BB_DISABLE_ASSERTS - goblin.cpp: remove debug trace checker Please read [contributing guidelines](CONTRIBUTING.md) and remove this line. For audit-related pull requests, please use the [audit PR template](?expand=1&template=audit.md). --------- Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com>
…b/goblin_flush_impl
federicobarbacovi
added
ci-full
federicobarbacovi
requested review from
IlyasRidhuan,
LeilaWang,
fcarreiro and
jeanmon
as code owners
federicobarbacovi
removed request for
IlyasRidhuan,
LeilaWang,
fcarreiro and
jeanmon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.