Update Dockerfile to include TypeScript config#1339
Merged
Azgaar merged 2 commits intoAzgaar:masterfrom Mar 2, 2026
Merged
Conversation
Added TypeScript configuration and updated Vite config file.
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Docker build to successfully run the current Vite + TypeScript build pipeline when containerizing the app.
Changes:
- Copy
tsconfig.jsoninto the Docker build context sotsccan run duringnpm run build. - Update Docker build to use
vite.config.ts(instead ofvite.config.js). - Set
NETLIFY=trueduring the Docker build so the Vitebaseresolves to/for container hosting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added TypeScript configuration and updated Vite config file.
Description
I wanted to run the app as a docker container, and i noticed that the existing Dockerfile didn't work correctly anymore. After some troubleshooting i got it working, and that is this PR.
I have published the container as targetcrafter/fantasy-map-generator on Dockerhub so that anyone can run it, but am willing to take this down if an official version is published. This can be achieved quite easily using Github actions.
Type of change
Versioning
I have not updated as changing the Dockerfile doesn't affect the application in any way, it only makes sure the current version can be built into a docker image.