Fix trusted apply artifacts before redaction#1841
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1837 forward from main after #1839 and #1840.
ArtifactBundleBuildernow writes the canonical patch and changed-files bytes to a workflow-created private temporary apply channel immediately after production mount-diff capture and beforeArtifactRedactortransforms configured secret names or values. The workflow applies only validated, bounded canonical files from that channel and removes the root after apply, on normal failure paths, and through the existing exit/signal cleanup coordinator. The channel is outside the durable artifact root and is never added to manifests, reviewer evidence, failure artifacts, or uploads.Source Relationship
ArtifactBundleBuilder,captureMountDiffs, andArtifactRedactor, then invokes host apply.Verification
npm cinpm run buildTMPDIR=/tmp npm run test:redactionTMPDIR=/tmp npm run test:runner-workspace-applyTMPDIR=/tmp npm run test:trusted-apply-artifact-channelnpm run test:native-agent-task-lifecycleThe production-path test uses
CONFIGURED_SECRETin unchanged patch context. It demonstrates the previous post-redaction artifact is unusable for apply, proves the private pre-redaction bytes apply to the host, and proves the durable patch uses[REDACTED:configured-secret-name].Compatibility
No public API, schema, or generated changelog changes. Runner-workspace apply now consumes its existing canonical artifacts from a private transient channel; durable/reviewer/uploaded artifact behavior remains redacted under the existing #64 contract.
AI Assistance
Implemented with AI assistance; changes and verification were reviewed and run locally.