Fix Push MD release bundle and show PR URL after push#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
LineDifferfrom the built artifact and execute a smoke diffWhy
The v0.6.9 WordPress.org artifact fatals while rendering a Pull Request because
PushMDVendor\WordPress\Merge\Diff\LineDifferis not present in the release bundle. Development and E2E installs use the monorepo source tree, which masked the missing manifest entries. Returning the Pull Request URL also lets the person pushing open the review directly from the terminal.Validation
bash bin/build-plugins.shbash bin/inspect-push-md-zip.shvendor/bin/phpunit plugins/push-md/Tests/(31 tests, 36 assertions, 12 skipped E2E tests)plugins/push-md/class-push-md-plugin.phpbash -n bin/inspect-push-md-zip.shgit diff --checkcomposer lintstill exits non-zero on existing repository warnings; changed production PHP passes targeted PHPCS.