HttpClient: Separate Client from Transports#19
Merged
Conversation
adamziel
marked this pull request as draft
May 26, 2025 11:18
adamziel
force-pushed
the
transports-middlewares
branch
from
May 26, 2025 11:55
ace7a24 to
c09420e
Compare
adamziel
marked this pull request as ready for review
May 29, 2025 20:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces inheritance (AbstractClient > CurlClient, SocketsClient) with a single Client class that uses either a
SocketsTransportorCurlTransport:This is a pre-requisite to #18
Testing instructions
Tests are included – confirm the CI checks pass