Skip to content

feat: fix redundant "first invented" / "invented for the first time"#3790

Merged
hippietrail merged 10 commits into
Automattic:masterfrom
hippietrail:redundant-firsts-1129
Jul 23, 2026
Merged

feat: fix redundant "first invented" / "invented for the first time"#3790
hippietrail merged 10 commits into
Automattic:masterfrom
hippietrail:redundant-firsts-1129

Conversation

@hippietrail

Copy link
Copy Markdown
Collaborator

Issues

Fixes #1129

Description

Flags verbs that imply the first time redundantly used with the word "first":

  • Invented for the first time
  • first invented

Some verbs make this implication with much more certainty, while others depend more on the context, so the message varies based on the verb.

The current patterns only cover the examples from the GitHub issue rather than trying to cover a wide range of hypothetical patterns. Running this on the fuzzer could be quite helpful.

So the chance of false negatives is reasonable. File bugs or comment here for false positives and negatives.

How Has This Been Tested?

cargo test

AI Disclosure

  • I am a human and didn't use any AI.
  • I used LLM features of my editor, but not an agent.
  • I used an AI agent interactively.
  • I am an agent or I got an agent to do the work autonomously.

I asked some AI for some coding idea but wrote all the code here myself.

If Your PR Implements or Enhances a Linter

  • I made up the sentences in the unit tests.
  • The sentences in the unit tests were generated by an AI.
  • I'm using examples from the bug report / feature request.
  • I collected real-world sentences for the unit tests.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

@hippietrail hippietrail added enhancement New feature or request rust Pull requests that update Rust code linting Related to lint rules and linter execution labels Jul 8, 2026
@hippietrail
hippietrail enabled auto-merge July 22, 2026 12:03
@hippietrail
hippietrail added this pull request to the merge queue Jul 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Jul 22, 2026
@hippietrail
hippietrail added this pull request to the merge queue Jul 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Jul 22, 2026
@hippietrail
hippietrail enabled auto-merge July 22, 2026 19:35
@hippietrail
hippietrail added this pull request to the merge queue Jul 23, 2026
Merged via the queue into Automattic:master with commit 110558d Jul 23, 2026
12 checks passed
@hippietrail
hippietrail deleted the redundant-firsts-1129 branch July 23, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request linting Related to lint rules and linter execution rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flag redundant firsts

1 participant