Author unassigned shaders under the mtl scope#2175
Draft
sebastienblor wants to merge 1 commit intoAutodesk:masterfrom
Draft
Author unassigned shaders under the mtl scope#2175sebastienblor wants to merge 1 commit intoAutodesk:masterfrom
sebastienblor wants to merge 1 commit intoAutodesk:masterfrom
Conversation
Collaborator
|
Some tests are failing on my machine and the CI : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
When we author unassigned shaders to usd, we want them to go under the mtl scope. So we need to apply a similar code to what is already done when shaders are assigned under a material. At the moment we only want to do that for actual arnold shaders, and not the other node types which are expressed as UsdShade
Adding test_2174
Issues fixed in this pull request
Fixes #2174